This repository has been archived by the owner on May 26, 2022. It is now read-only.
fix source address not being set in non REUSEPORT dialer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
fix/source-address
branch
from
bd54f66
to
534cc62
Compare
Kubuxu
force-pushed
the
fix/source-address
branch
from
534cc62
to
ae8aebd
Compare
|
It might still not be enough |
|
Could you rebase off of master? I fixed the minimum go version for travis (green check marks are pretty). Regardless, LGTM. Even if it's not enough, it's still strictly more correct. Is there an easy way to test this? |
Kubuxu
force-pushed
the
fix/source-address
branch
from
ae8aebd
to
b66ba39
Compare
|
There unfortunately isn't a good way to test for it. I will think more about it as I would really like to have test for it once I figure out how to make it not dial other addresses. |
Stebalien
force-pushed
the
fix/source-address
branch
from
b66ba39
to
5ebce0e
Compare
ghost
assigned
|
Tested locally. |
This was referenced Dec 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ipfs/kubo#4088