Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add raw connection and transport tag to Connection interface #79

Closed
wants to merge 7 commits into from

Conversation

HexaField
Copy link

@HexaField HexaField commented Jan 1, 2021

Adds the ability to optionally expose the raw connection of a transport as well as to provide a transport identifier tag in the Connection interface.

Changes:

MultiaddrConnection type now has optional transportTag parameter
Connection class now has optional rawConn and transportTag parameters

Solves in part libp2p/js-libp2p#838

Copy link
Member

@vasco-santos vasco-santos left a comment

@HexaField sorry for the late review. Let's get to add this feature now.

Per libp2p/js-libp2p#838 (comment) we should expose the multiaddrConn which will include the raw connection underneath.

@jacobheun jacobheun added the status/in-progress In progress label Mar 22, 2021
@jacobheun
Copy link
Contributor

jacobheun commented Mar 22, 2021

For the connection we should just expose the multiaddr connection instead of its underlying raw connection. I don't think we need the transportTag, we should be able to inspect this via the multiaddresses.

@lidel
Copy link
Member

lidel commented Mar 29, 2021

Closing this PR as we'd like to just expose the underlying connection per libp2p/js-libp2p#838 (comment)

@lidel lidel closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants