This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix/only tcp #55
Merged
fix/only tcp #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haadcode
approved these changes
Jan 19, 2017
| @@ -115,8 +120,7 @@ class MulticastDNS extends EventEmitter { | |||
| data: peerInfo.id.toB58String() + '.' + serviceTag | |||
| }) | |||
|
|
|||
| // Only announce TCP multiaddrs for now | |||
| const multiaddrs = tcp.filter(peerInfo.multiaddrs) | |||
| // TODO announce all the TCP multiaddrs | |||
| const port = multiaddrs[0].toString().split('/')[4] | |||
There was a problem hiding this comment.
Should we check the existance of multiaddrs[0] as well as the existance of the 4th element in the split array?
There was a problem hiding this comment.
Ignore the comment, I see you did that above! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.