From 24c5b37ab64429972f29af6ae4516c18232d1ff3 Mon Sep 17 00:00:00 2001
From: Alex Potsides <alex@achingbrain.net>
Date: Thu, 17 Nov 2022 12:44:35 +0200
Subject: [PATCH] fix: update metric names to follow prometheus naming guide
 (#228)

The [Prometheus metric naming guidelines](https://prometheus.io/docs/practices/naming/) say they should have suffixes like `_total` for unit-less counts and `_info` for metadata.
---
 src/listener.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/listener.ts b/src/listener.ts
index 8546084..d7611d4 100644
--- a/src/listener.ts
+++ b/src/listener.ts
@@ -83,7 +83,7 @@ export class TCPListener extends EventEmitter<ListenerEvents> implements Listene
             addr = `${address.address}:${address.port}`
           }
 
-          context.metrics?.registerMetric(`libp2p_tcp_connections_${addr}_count`, {
+          context.metrics?.registerMetric(`libp2p_tcp_connections_${addr}_total`, {
             help: 'Current active connections in TCP listener',
             calculate: () => {
               return this.connections.size
@@ -91,14 +91,14 @@ export class TCPListener extends EventEmitter<ListenerEvents> implements Listene
           })
 
           this.metrics = {
-            status: context.metrics.registerMetric(`libp2p_tcp_${addr}_server_status`, {
+            status: context.metrics.registerMetric(`libp2p_tcp_${addr}_server_status_info`, {
               help: 'Current status of the TCP server'
             }),
             errors: context.metrics.registerCounterGroup(`libp2p_tcp_${addr}_server_errors_total`, {
               label: 'error',
               help: 'Total count of TCP listener errors by error type'
             }),
-            events: context.metrics.registerCounterGroup(`libp2p_tcp_$${addr}_socket_events`, {
+            events: context.metrics.registerCounterGroup(`libp2p_tcp_${addr}_socket_events_total`, {
               label: 'event',
               help: 'Total count of TCP socket events by event'
             })