From e6a41f7e9b8c06babfdec9852f0e5355d3405fd0 Mon Sep 17 00:00:00 2001 From: Chad Nehemiah Date: Mon, 31 Jul 2023 02:05:02 -0500 Subject: [PATCH] fix: update max message size SDP attribute (#1909) Updates max message size to comply with spec. Closes https://github.com/libp2p/js-libp2p/issues/1908 --- packages/transport-webrtc/src/private-to-public/sdp.ts | 2 +- packages/transport-webrtc/test/sdp.spec.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/transport-webrtc/src/private-to-public/sdp.ts b/packages/transport-webrtc/src/private-to-public/sdp.ts index 474455021f..c487c8c57d 100644 --- a/packages/transport-webrtc/src/private-to-public/sdp.ts +++ b/packages/transport-webrtc/src/private-to-public/sdp.ts @@ -133,7 +133,7 @@ a=ice-ufrag:${ufrag} a=ice-pwd:${ufrag} a=fingerprint:${CERTFP} a=sctp-port:5000 -a=max-message-size:100000 +a=max-message-size:16384 a=candidate:1467250027 1 UDP 1467250027 ${host} ${port} typ host\r\n` } diff --git a/packages/transport-webrtc/test/sdp.spec.ts b/packages/transport-webrtc/test/sdp.spec.ts index 2c32f7967b..cff8a794b1 100644 --- a/packages/transport-webrtc/test/sdp.spec.ts +++ b/packages/transport-webrtc/test/sdp.spec.ts @@ -17,7 +17,7 @@ a=ice-ufrag:MyUserFragment a=ice-pwd:MyUserFragment a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1 a=sctp-port:5000 -a=max-message-size:100000 +a=max-message-size:16384 a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host` describe('SDP', () => { @@ -73,7 +73,7 @@ a=ice-ufrag:someotheruserfragmentstring a=ice-pwd:someotheruserfragmentstring a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1 a=sctp-port:5000 -a=max-message-size:100000 +a=max-message-size:16384 a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host` expect(result.sdp).to.equal(expected)