Check if entry exists in dictionary before delete #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,8 @@ def shift(self) -> None: | |||
| last_entries: List[CacheEntry] = self.history[len(self.history) - 1] | |||
|
|
|||
| for entry in last_entries: | |||
| del self.msgs[entry.mid] | |||
| if entry.mid in self.msgs: | |||
There was a problem hiding this comment.
It's a minimal improvement but you can also do self.msgs.pop(encry.mid, None). Slightly more robust as it's also threadsafe though admittedly that probably doesn't matter much here.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into
KeyErrorwhen our peer in a stream accidentallycloseandresetthe stream because handlers for both will try todel streams[stream_id]without checking if the entry still exists.