Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelogs for prost dep update #2851

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Aug 26, 2022

Description

Patch changelogs for #2788

Links to any relevant issues

#2848

Open Questions

na

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation does not apply
  • I have added tests that prove my fix is effective or that my feature works does not apply
  • A changelog entry has been made in the appropriate crates

@divagant-martian divagant-martian marked this pull request as ready for review August 29, 2022 15:08
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @divagant-martian!

@mxinden mxinden merged commit 36a2773 into libp2p:master Aug 30, 2022
@dignifiedquire
Copy link
Member

thanks for the update. just a general note this is really painful when using libp2p now, as all ci flows have to be updated to manually install protoc, really unfortunate for downstream users

@mxinden
Copy link
Member

mxinden commented Aug 31, 2022

Agreed @dignifiedquire, though I don't see a solution. Do you?

I don't think this is libp2p specific, but applies to any application using prost.

@dignifiedquire
Copy link
Member

agree it is a general prost problem, one idea I had is to make a rust crate that brings protoc with it, so one could include in its build deps

@jxs
Copy link
Member

jxs commented Sep 4, 2022

It seems tokio-rs/prost#620 addresses that, but has been stagnant since tokio-rs/prost#657

@AgeManning AgeManning deleted the update-changelogs branch November 29, 2023 05:12
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants