Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop testing mplex #196

Open
Tracked by #553
marten-seemann opened this issue Jun 15, 2023 · 2 comments
Open
Tracked by #553

stop testing mplex #196

marten-seemann opened this issue Jun 15, 2023 · 2 comments

Comments

@marten-seemann
Copy link
Contributor

mplex is being phased out. go-libp2p and rust-libp2p have removed it from the list of default muxers a long time ago.
Kubo is considering removing it as well: ipfs/kubo#9958.

@p-shahi
Copy link
Member

p-shahi commented Jun 15, 2023

Is it premature to stop testing mplex until this comment libp2p/specs#553 (comment) hold true and it's actually deprecated in the libp2p/specs?

The first step would be for every client to have yamux enabled by default (which requires stable support in their underlying libp2ps, and proper testing)
Once that is done & we are confident in all yamuxes, we can update the specs to remove mandatory support

mplex also seems to acheive better performance than yamux: ChainSafe/js-libp2p-yamux#42 in js-libp2p

@marten-seemann
Copy link
Contributor Author

This is more about documenting what we're already doing now. We're not fixing bugs or performance issues in mplex, instead, we're already skipping tests (see the transport integration test effort in go-libp2p).

If we resolve the specs issue first and then disable the tests or vice versa will most likely not make any difference.

@marten-seemann marten-seemann linked a pull request Aug 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants