Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade to winapi 0.3 #363
This PR is to move away from legacy winapi 0.2 and related *-sys crates to winapi 0.3.x. Note, this is currently using my git branch iphlpapi as required changes have not yet been merged into upstream, yet.
This is my second PR ever, and I'm pretty green with github, merges, forks, etc.., so I do apologize for rookie mistakes in advance and welcome any and all commentary/criticism.
This is a WIP PR, I updated to winapi 0.3 naively using rust-2018 and nightly. I need to go back and support this project's minimum Rust version. winapi 0.3 supports back to rust 1.6 so there should be no issues there.
Tests are not yet passing, for me.
I think this looks good overall - I've left a few comments.
I won't merge this until the upstream changes have made their way into
I'm a bit busy at the moment - if you're able to idle on IRC you can ask questions and I'll respond when I can.
Re: Minimum supported version - this can be bumped as high as it needs to go, I don't have a problem with that. Just needs the CI and docs updating to mention it.
Re: 2018 - I'm happy to move libpnet to it, but it should be in a separate PR.
@mrmonday No rush, I can be patient (overly eager lol). I will address each of your comments, but also ask some questions, too. I can indeed idle on IRC.
RE: version and 2018, I wasn't even thinking about the fact that cargo essentially snapshots versions, so we can move the github project forward, while not breaking existing deployed code. I will create an issue to move to 2018 and bump versions. Will do a PR for it once ready.