-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update to libmozjs 24 #32
Comments
|
I have the patches for this and will be posting them shortly assuming they get through the company IP review. Can you test them (testing them has been a bit of a problem) |
|
Ok, that was painless this time. Check the pull requests for the patch. |
|
+1 for updating targetting mozjs version By the way, GNOME is moving to mozjs31: https://git.gnome.org/browse/gjs/log/?h=wip/ptomato/mozjs31. How about re-target libproxy to mozjs 31 instead? Or even crazy, mozjs45? I have a patch for mozjs45 that runs fine with the simplest PAC. |
|
I would be +1 for mozjs45 (or even 52 which is due out soon and will be another LTE) |
|
Agreed - 45 would be a nice target |
|
Now that 52 is out and is an LTE too, it's definitely the best choice, imo |
|
@Keruspe Do you know where I can find a source tarball for js52? https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Releases doesn't have it. |
|
FTR it seems that GNOME and polkit are moving to mozjs38 Would be a better idea to use that version and stick to GNOME? |
|
Yes, or even a newer version. Latest LTR is 52 I believe |
|
@nullr0ute yes sure, but for the distributions (and for the endusers) it would be better to only have one mozjs library available (and loaded in memory) Looking at the reverse dependencies of libproxy there are high chances that it's used on a GNOME desktop |
|
I've been doing the rounds for pacrunner and polkit, with updates to mozjs38. Let me see about a patch for libproxy as well. |
|
A news from Phoronix: http://phoronix.com/scan.php?page=news_item&px=GJS-Plans-For-GNOME-3.26 GJS is moving to mozjs52, so let's do the same :) |
|
@DimStar77 could we get a new release now that the port to spidermonkey 38 has been merged? And maybe close this issue and open a new one for a port to spidermonkey 52? |
|
@Keruspe - Thanks for the reminder.. I tagged 0.4.15 and published it. Let's close this issue for now. Thank you all for working on this and helping moving this forward! |
Hi,
libproxy currently uses libmozjs 1.8.5 which is quite old.
Would be nice if it was updated to use libmozjs 24
Thanks
The text was updated successfully, but these errors were encountered: