Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to libmozjs 24 #32

Closed
bigon opened this issue Aug 2, 2016 · 15 comments
Closed

Please update to libmozjs 24 #32

bigon opened this issue Aug 2, 2016 · 15 comments

Comments

@bigon
Copy link
Contributor

bigon commented Aug 2, 2016

Hi,

libproxy currently uses libmozjs 1.8.5 which is quite old.

Would be nice if it was updated to use libmozjs 24

Thanks

@DimStar77 DimStar77 added this to the 0.4.14 milestone Aug 4, 2016
@jlinton
Copy link
Contributor

jlinton commented Aug 19, 2016

I have the patches for this and will be posting them shortly assuming they get through the company IP review.

Can you test them (testing them has been a bit of a problem)

@jlinton
Copy link
Contributor

jlinton commented Aug 19, 2016

Ok, that was painless this time. Check the pull requests for the patch.

#36

@yan12125
Copy link

yan12125 commented Nov 3, 2016

+1 for updating targetting mozjs version

By the way, GNOME is moving to mozjs31: https://git.gnome.org/browse/gjs/log/?h=wip/ptomato/mozjs31. How about re-target libproxy to mozjs 31 instead? Or even crazy, mozjs45? I have a patch for mozjs45 that runs fine with the simplest PAC.

@nullr0ute
Copy link

I would be +1 for mozjs45 (or even 52 which is due out soon and will be another LTE)

@DimStar77
Copy link
Contributor

Agreed - 45 would be a nice target

@Keruspe
Copy link

Keruspe commented Mar 8, 2017

Now that 52 is out and is an LTE too, it's definitely the best choice, imo

@yan12125
Copy link

@Keruspe Do you know where I can find a source tarball for js52? https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Releases doesn't have it.

@bigon
Copy link
Contributor Author

bigon commented Apr 19, 2017

FTR it seems that GNOME and polkit are moving to mozjs38

Would be a better idea to use that version and stick to GNOME?

@nullr0ute
Copy link

Yes, or even a newer version. Latest LTR is 52 I believe

@bigon
Copy link
Contributor Author

bigon commented Apr 19, 2017

@nullr0ute yes sure, but for the distributions (and for the endusers) it would be better to only have one mozjs library available (and loaded in memory)

Looking at the reverse dependencies of libproxy there are high chances that it's used on a GNOME desktop

@jlinton
Copy link
Contributor

jlinton commented Apr 19, 2017

I've been doing the rounds for pacrunner and polkit, with updates to mozjs38. Let me see about a patch for libproxy as well.

@yan12125
Copy link

A news from Phoronix: http://phoronix.com/scan.php?page=news_item&px=GJS-Plans-For-GNOME-3.26

GJS is moving to mozjs52, so let's do the same :)

@Keruspe
Copy link

Keruspe commented May 11, 2017

@DimStar77 could we get a new release now that the port to spidermonkey 38 has been merged?

And maybe close this issue and open a new one for a port to spidermonkey 52?

@DimStar77 DimStar77 modified the milestones: 0.4.14, 0.4.15 May 11, 2017
@DimStar77
Copy link
Contributor

@Keruspe - Thanks for the reminder.. I tagged 0.4.15 and published it.

Let's close this issue for now. Thank you all for working on this and helping moving this forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants