Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

29% size reduction of image assets using lossless compression from ImgBot #87

Closed
wants to merge 1 commit into from

Conversation

@armujahid
Copy link

commented Jun 19, 2019

Beep boop. Your images are optimized!

Your image file size has been reduced by 29% 馃帀

Details
File Before After Percent reduction
/libra.png 14.20kb 4.63kb 67.38%
/.assets/libra.png 14.20kb 4.63kb 67.38%
/storage/data.png 574.90kb 421.59kb 26.67%
Total : 603.29kb 430.86kb 28.58%

馃摑docs | :octocat: repo | 馃檵issues | 馃弲swag | 馃彧marketplace

Motivation

This is an automatic image optimization commit from ImgBot

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No testing is required since this is a signed commit from ImgBot related to lossless compression of images.

Related PRs

N/A

@armujahid armujahid changed the title [ImgBot] Optimize images 29% size reduction of image assets using lossless compression from ImgBot Jun 19, 2019
@ericnakagawa

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

Thanks for the PR @armujahid. We could definitely use better compression on our image binaries. Our team is reviewing your PR and will reply back soon. We're still sorting out CLAs and will reply back with an update.

Copy link
Contributor

left a comment

Thanks for the contribution! This looks like a good change.

However, due to some CI changes, to get CI to run we would need you to rebase this PR. Going forward this won't be an issue, but unfortunately, we do not have a nice way to force CI to run for older PRs.

Also, have you looked at our CLA?

@bmwill

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

@huitseeker bors should be able to handle this, so as long as we can merge it we shouldn't need anything from the original contributor

@armujahid

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

@huitseeker yes I have already seen CLA. This commit is from a bot so I am not its original author anyway. I will rebase it today to trigger CI hooks again.

*Total -- 603.29kb -> 430.86kb (28.58%)

/libra.png -- 14.20kb -> 4.63kb (67.38%)
/.assets/libra.png -- 14.20kb -> 4.63kb (67.38%)
/storage/data.png -- 574.90kb -> 421.59kb (26.67%)
@armujahid armujahid force-pushed the armujahid:imgbot branch from 341a2ef to c672375 Sep 18, 2019
@armujahid

This comment has been minimized.

Copy link
Author

commented Sep 18, 2019

Rebased and all checks have passed. I have also sent my signed CLA

@ericnakagawa ericnakagawa added cla and removed needs-cla labels Sep 18, 2019
@ericnakagawa

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@armujahid Thanks for the contribution. Your CLA has been received.

@ericnakagawa

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@bors-libra

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

馃搶 Commit c672375 has been approved by ericnakagawa

@bors-libra

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

鈱涳笍 Testing commit c672375 with merge 6d6953a...

@bors-libra

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

鈽锔 Test successful - checks-circle_commit_workflow
Approved by: ericnakagawa
Pushing 6d6953a to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.