Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda return Lockfile, or Manifest, not both in one response. #467

Merged
merged 8 commits into from Oct 1, 2019

Conversation

@tyrelsouza
Copy link
Member

commented Sep 30, 2019

conda-parser change is live, so updated VCR records.
of course new versions have released, so the responses are slightly different with versions.

Also only returning one type, so NO MORE HARDCODING making a Bibliothecary::Analyser.create_analysis( i can just return json!

For more context, see librariesio/conda-parser#16

tyrelsouza added 7 commits Sep 30, 2019
… record VCR, will do after
…akes it easier:
@@ -17,116 +17,98 @@
{:name=>"ncurses", :requirement=>"6.1", :type=>"runtime"},
{:name=>"numpy", :requirement=>"1.16.4", :type=>"runtime"},
{:name=>"openssl", :requirement=>"1.1.1c", :type=>"runtime"},
{:name=>"pip", :requirement=>"19.2.2", :type=>"runtime"},

This comment has been minimized.

Copy link
@tyrelsouza

tyrelsouza Oct 1, 2019

Author Member

no version because we're not resolving the version now for manifests, just returning as is. this example file has pip and setuptools without versions

@tyrelsouza tyrelsouza marked this pull request as ready for review Oct 1, 2019
@tyrelsouza tyrelsouza requested review from havocp, kbarrette and mikeyoung85 Oct 1, 2019
}
end

# Overrides Analyser.analyse_contents_from_info
def self.analyse_contents_from_info(info)

This comment has been minimized.

Copy link
@tyrelsouza

tyrelsouza Oct 1, 2019

Author Member

GOOD BYE OVERRIDE!

def self.parse_conda(info)
results = call_conda_parser_web(info.contents)
FILE_KINDS.map do |kind|
Bibliothecary::Analyser.create_analysis(

This comment has been minimized.

Copy link
@tyrelsouza

tyrelsouza Oct 1, 2019

Author Member

SEE YA Explicit Creation

@katzj
katzj approved these changes Oct 1, 2019
@havocp
havocp approved these changes Oct 1, 2019
Copy link
Contributor

left a comment

lgtm!

@tyrelsouza tyrelsouza merged commit cb77104 into master Oct 1, 2019
3 checks passed
3 checks passed
Tidelift Dependencies checked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tyrelsouza tyrelsouza deleted the make_conda_return_one_each branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.