Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update cookbook with Foodcritic tests #4

merged 5 commits into from Sep 26, 2012


None yet
2 participants

pwelch commented Sep 26, 2012

Update the cookbook with changes from Foodcritic Tests.

Paul Welch added some commits Sep 26, 2012

FC001 Cleanup
This commit updates cookbook with Foodcritic Rule FC001:
Use strings in preference to symbols to access node attributes.
This commit also cleans up some unnecessary whitespace.
FC011 Cleanup
This commit updates the cookbook to fix Foodcritic rule FC011:
Missing README in markdown format.
This commit also fixes parts of the README for change to markdown.
Merge branches 'master' and 'update_cookbook'
* master:

* update_cookbook:
  Update metadata to use README.md instead of README.rdoc
  FC011 Cleanup
  FC001 Cleanup

@mheffner mheffner and 1 other commented on an outdated diff Sep 26, 2012

@@ -54,16 +53,15 @@
# Sort to preserve order of the config
- watch_file_array = watch_file_array.sort { |a,b| a[:filename] <=> b[:filename] }
+ watch_file_array = watch_file_array.sort { |a,b| a['filename'] <=> b['filename'] }

mheffner Sep 26, 2012


Have you tested whether changing the keys from symbols -> keys works here? Since watch_file_array is built as a simple hash, will this still support the indifferent key access? The other key changes appear fine.


pwelch Sep 26, 2012


Good catch. That should not have been changed. Updated with commit ddda39a

Fix hash from FC001 commit.
This commit changes the hash watch_file_array back to symbols.
This should not have been changed during the Foddcritic tests.

mheffner added a commit that referenced this pull request Sep 26, 2012

Merge pull request #4 from pwelch/master
Update cookbook with Foodcritic tests

@mheffner mheffner merged commit 3092a2a into librato:master Sep 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment