Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

add a function that will actually list all metrics #82

Merged
merged 1 commit into from Mar 27, 2015

Conversation

Bachmann1234
Copy link
Contributor

I wrote this to help me with a script im playing with. If y'all like it I can polish it

@jderrett
Copy link
Contributor

@drio thoughts on this usage?

>>> api.list_all_metrics()
<generator object list_all_metrics at 0x108167c80>
>>> len(list(api.list_all_metrics()))
166

@drio
Copy link
Contributor

drio commented Mar 25, 2015

I will take a look and get back to you.

@drio
Copy link
Contributor

drio commented Mar 26, 2015

Ok, this looks great, big 👍 (thanks @Bachmann1234).
At some point we may want list_metrics() to become an alias of list_all_metrics().

@jderrett If you are also fine with this PR I will merge it (I'll also modify the README) and push a new version asap.

@jderrett
Copy link
Contributor

👍 thanks guys!

drio added a commit that referenced this pull request Mar 27, 2015
add a function that will actually list all metrics
@drio drio merged commit 6b07983 into librato:master Mar 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants