Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a LibreCores CI Image for OpenRISC, RISC V Image now inherits the main LibreCores CI one #20

Merged
merged 4 commits into from Jul 11, 2019

Conversation

@Nancy-Chauhan
Copy link
Member

commented Jun 17, 2019

Solves #19 #18

@oleg-nenashev
Copy link
Contributor

left a comment

With the current version the build will not be reproducible. I suggest pinning all versions instead of relying on latest

librecores-ci-openrisc/Dockerfile Outdated Show resolved Hide resolved
librecores-ci-openrisc/Dockerfile Outdated Show resolved Hide resolved
@oleg-nenashev
Copy link
Contributor

left a comment

Fine with me. Is it still a draft? Or should I merge it and see whether it works on DockerHib?

@Nancy-Chauhan Nancy-Chauhan marked this pull request as ready for review Jul 8, 2019

@Nancy-Chauhan

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

@oleg-nenashev This should work now.

@stffrdhrn

This comment has been minimized.

Copy link

commented Jul 9, 2019

This looks nice to have all the tools installed

@oleg-nenashev
Copy link
Contributor

left a comment

Would be nice to have some documentation, but we can do it later

@oleg-nenashev oleg-nenashev changed the title Rework on docker-images Create a LibreCores CI Image for OpenRISC, RISC V Image now inherits the main LibreCores CI one Jul 11, 2019

@oleg-nenashev oleg-nenashev merged commit 581ff07 into librecores:master Jul 11, 2019

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

The PR was amended in #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.