New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for private Vagrant config #145

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
3 participants
@agathver
Copy link
Collaborator

agathver commented Jun 2, 2017

Allows the developer to customize Vagrant configuration as needed locally.

Why ?

Because symfony cache generation, batch operations on MySQL on the VM was very slow, I wanted to run the VM in another powerful machine in my home network.

@@ -54,3 +54,5 @@ Vagrant.configure("2") do |config|
end
end

private_vagrantfile = File.expand_path('../Vagrantfile.private', __FILE__)

This comment has been minimized.

@imphil

imphil Jun 4, 2017

Contributor

Is this really looking for SRCDIR/vagrant/Vagrantfile.private and not for SRCDIR/Vagrantfile.private?

This comment has been minimized.

@agathver

agathver Jun 4, 2017

Collaborator

Strange ruby way from ruby v1, I'll update it to a more cleaner ruby v2 way

v.memory = 2048
end
end
```

This comment has been minimized.

@imphil

imphil Jun 4, 2017

Contributor

Could you either add this documentation to http://librecores-web.readthedocs.io/en/latest/devenv/quickstart.html (sources are in the docs folder of the source tree), or add at least a pointer to this README there?

@agathver agathver force-pushed the agathver:private-vagrant branch from b431880 to c7f4566 Jun 7, 2017

@agathver

This comment has been minimized.

Copy link
Collaborator

agathver commented Jun 7, 2017

I've added info about Vagrantfile.private in the docs and changed __FILE__ to __dir__

@oleg-nenashev
Copy link
Collaborator

oleg-nenashev left a comment

The current level of documentation looks good to me. Readthedocs is a separate story I'd guess

@imphil imphil merged commit a4ecaae into librecores:master Jun 7, 2017

@imphil

This comment has been minimized.

Copy link
Contributor

imphil commented Jun 7, 2017

Great, thanks @agathver

@agathver agathver deleted the agathver:private-vagrant branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment