Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add functional tests for routes #152
This commit recreates part of the deployment rules we have in Ansible today inside the travis configuration. I'm not convinced this is a viable path in the longer term:
In my opinion a more viable long-term approach would be:
@imphil The main aim of these tests is to make sure that a PR accidentally does not break any feature due to modifying components which other parts are dependent on. This does not aim to be a full replacement for an "integration test" for which we will continue to need a staging box.
What it aims to do:
For testing all the parts correctly, we undoubtedly need Selenium or equivalent on a staging environment configured identical to the production environment.
Additionally, we can create a testing enviornment inside a sudo-enabled Travis CI by running the ansible provisioner inside Travis, and performing HTTP tests on it.
I agree with the goals, just the deployment part inside travis.yml replicating our setup is pretty fragile in my opinion. So let's do it this way:
I hope this approach doesn't block your development process, but also makes it clear that this solution won't stay (and shouldn't stay).