Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK]: Add a emailer and send confirmation email #208

Closed

Conversation

@sandipbhuyan
Copy link
Collaborator

@sandipbhuyan sandipbhuyan commented Feb 24, 2018

Closes #142

I used the feature of FOSUserBundler. I have added two extra parameters i.e mailer_encryption and mailer_auth_mode for the encryption and authentication of mailing services.

The confirmation link is going through an emailer template which is in emailer.html.twig.

The email which the user will receive will be like:
screen shot 2018-02-24 at 9 31 19 pm

@sandipbhuyan
Copy link
Collaborator Author

@sandipbhuyan sandipbhuyan commented Feb 24, 2018

@agathver @imphil PR for issue #142

Loading

@@ -7,6 +7,8 @@ parameters:
database_user: librecores
database_password: ~

mailer_auth_mode: login #the type of authentication the mailer is checking eg: 'login'
Copy link
Collaborator

@recrsn recrsn Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is required, the plan is to go with AWS SES, which supports plain auth`.

Loading

</td>
</tr>
</table>

Copy link
Collaborator

@recrsn recrsn Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better (and required in some legislations) to add a mail footer: https://codepen.io/rodriguezcommaj/pen/RNPzwr

Please add LibreCores contact address and why they received this email something like "you have received this email as you or someone posing as you have signed-up at LibreCores"

Loading

Copy link
Collaborator Author

@sandipbhuyan sandipbhuyan Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the content for the mail footer. i have checked the librecores website but didn't get any address which i can use in the footer

Loading

@recrsn
Copy link
Collaborator

@recrsn recrsn commented Feb 24, 2018

@sandipbhuyan What is the sandy that you display? Username? First name?

Loading

address: 'noreply@librecores.org'
sender_name: 'LibreCores'
enabled: true # change to true for required email confirmation
template: 'emailer.html.twig' #custom emailer template
Copy link
Collaborator

@recrsn recrsn Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of assigning a custom template name, I would prefer you to override the default FOSUserBundle templates as in #193

Also add a plain-text version of the email for better support of mobile and command-line clients.

Loading

Copy link
Contributor

@imphil imphil Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use: "LibreCores is a project by The Free and Open Source Silicon Foundation C.i.C., 71-75 Shelton Street, London, WC2H 9JQ, United Kingdom"

Loading

@sandipbhuyan
Copy link
Collaborator Author

@sandipbhuyan sandipbhuyan commented Feb 24, 2018

@agathver sandy refers to the username

Loading

@sandipbhuyan
Copy link
Collaborator Author

@sandipbhuyan sandipbhuyan commented Feb 25, 2018

@agathver @imphil I have made some changes
The email the users are getting will be like
screen shot 2018-02-25 at 8 08 15 pm
And I have modified the README of sites directory.I have added details about salt email template.

Loading

Copy link
Collaborator

@recrsn recrsn left a comment

Just a little typo, apart from that, LGTM

Loading

<table width="500" border="0" cellspacing="0" cellpadding="0" align="center" class="responsive-table">
<tr>
<td align="center" valign="middle" style="font-size: 12px; line-height: 18px; font-family: Helvetica, Arial, sans-serif; color:#666666;">
<span class="appleFooter" style="color:#666666;"> 71-75 Shelton Street, London, WC2H 9JQ, United Kingdom</span><br><a style="color: #666666; text-decoration: none;">you are receiving this email because you (or someone posing as you) signed up at LibreCores</a>
Copy link
Collaborator

@recrsn recrsn Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you -> You

Loading

@sandipbhuyan sandipbhuyan force-pushed the confirmation-email branch from 98df417 to 1510dbe Feb 28, 2018
recrsn
recrsn approved these changes Mar 1, 2018
Copy link
Collaborator

@recrsn recrsn left a comment

LGTM

Loading

@recrsn
Copy link
Collaborator

@recrsn recrsn commented Mar 1, 2018

@imphil, In the current form, this looks good to me. We should go ahead and configure SES to make this run.

Loading

@imphil
Copy link
Contributor

@imphil imphil commented Mar 1, 2018

Thanks @sandipbhuyan for this PR. I've slightly modified it and added the necessary deployment code. There are a couple more things to be done on my side to correctly configure Amazon SES in all its glory, but we should be able to send out mails soon! I've also opened a couple follow-up issues (#212 , #211) with things I noted when giving the changeset a try.

The final commit was e8c0ecc

Loading

@imphil imphil closed this Mar 1, 2018
@sandipbhuyan
Copy link
Collaborator Author

@sandipbhuyan sandipbhuyan commented Mar 2, 2018

Thanks @imphil for merging this PR. I will be working shortly on the relative issues (#212 , #210 , #211 )

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants