Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list of GitHub repos searchable in project import #213

Closed
wants to merge 2 commits into from

Conversation

@sandipbhuyan
Copy link
Collaborator

commented Mar 2, 2018

# Resolving issue #196

Now selection of git project will have a UI with search functionality. A user directly can search over a number of projects.
I have added and imported two libraries of bootstrap-select i.e bootstrap-select.min.css and bootstrap-select.min.js in base.html.twig.
I have modified the drop down section's z-index to over ride the z-index property of navbar.
The UI will look like:
screen shot 2018-03-02 at 1 51 54 pm

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 2, 2018

@agathver and @imphil I have raised a PR against the issue #196.

@agathver agathver changed the title [ENHANCEMENT][BUG]: To apply bootstrap select function in selection o… Make list of GitHub repos searchable in project import Mar 2, 2018

@agathver
Copy link
Collaborator

left a comment

Please add the un-minified files, we already have a build system (assetic) which handles minifying.

Overall, the UI looks good to me.

@@ -134,7 +135,7 @@
</footer>

{% block javascripts %}
{% javascripts filter="?jsqueeze" output="js/app_body.js" '@js_body_end' %}
{% javascripts filter="?jsqueeze" output="js/app_body.js" '@js_body_end' 'assets/js/bootstrap-select.min.js' %}

This comment has been minimized.

Copy link
@agathver

agathver Mar 2, 2018

Collaborator

Should this be present in every page load?

I would rather prefer it to be included in ProjectRepoBundle::Project::new.html.twig

This comment has been minimized.

Copy link
@imphil

imphil Mar 2, 2018

Contributor

yes, please make it only for the "new project" page.

{{ form_row(form.githubSourceRepo, {'label': 'Select a project from your GitHub account'}) }}
<div class="form-group">
{{ form_label(form.githubSourceRepo,'Select a project from your GitHub account') }}
{{ form_widget(form.githubSourceRepo,{'attr': {'class': 'selectpicker','data-live-search':'true'}}) }}

This comment has been minimized.

Copy link
@imphil

imphil Mar 2, 2018

Contributor

two nits: please add a space after the comma, e.g. form.githubSourceRepo, {'attr':

@@ -134,7 +135,7 @@
</footer>

{% block javascripts %}
{% javascripts filter="?jsqueeze" output="js/app_body.js" '@js_body_end' %}
{% javascripts filter="?jsqueeze" output="js/app_body.js" '@js_body_end' 'assets/js/bootstrap-select.min.js' %}

This comment has been minimized.

Copy link
@imphil

imphil Mar 2, 2018

Contributor

yes, please make it only for the "new project" page.

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 4, 2018

@agathver @imphil I have made the changes in which i imported both the css and js file in new.html.twig and i have added the un-minified file of js and css

@agathver
Copy link
Collaborator

left a comment

LGTM

@imphil

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2018

Great, thanks! Rebased/merged via a63aa8a

@imphil imphil closed this Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.