Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling and Content of page after email is verified #216

Open
wants to merge 2 commits into
base: master
from

Conversation

@sandipbhuyan
Copy link
Collaborator

commented Mar 6, 2018

Resolving issue #210
I have added one page named as confirmed.html.twig that overrides the default confirm pages.
I have added some svg files for the content of the page.
The UI will be like
screen shot 2018-03-06 at 9 42 11 pm
screen shot 2018-03-06 at 9 41 31 pm

@imphil

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

Thanks for the changes. I'll look through them over the weekend. How can I test the page? Do I need to create a new account or are there other ways? (http://www.librecores.devel/user/register/confirmed gives me an exception 'Attempted to call an undefined method named "getProviderKey" of class "HWI\Bundle\OAuthBundle\Security\Core\Authentication\Token\OAuthToken".').

@agathver
Copy link
Collaborator

left a comment

Clarify that we are allowed to redistribute the files, with or without modifications

@agathver

This comment has been minimized.

Copy link
Collaborator

commented Mar 8, 2018

@imphil , make sure you are logged in

@imphil

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

I'm logged in, but through GitHub (OAuth). This seems to be a bug/missing feature in HWIOAuth, but I didn't find time to look at it yet.

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 8, 2018

@agathver I am replacing the icons with the open source files. @imphil you can see this page when you will confirm your account or go to the link http://www.librecores.devel/user/register/confirmed url after logged in

@sandipbhuyan sandipbhuyan force-pushed the sandipbhuyan:confirm-email-page branch from 543f93e to f4ea9aa Mar 8, 2018

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 9, 2018

@agathver @imphil I have replaced the icons with open source icons and added the author information on README

@sandipbhuyan sandipbhuyan force-pushed the sandipbhuyan:confirm-email-page branch from f4ea9aa to 36b5d49 Mar 10, 2018

@imphil

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2018

I've looked through it and I have some suggestions written inside the image itself.

librecores

@sandipbhuyan sandipbhuyan force-pushed the sandipbhuyan:confirm-email-page branch from 36b5d49 to a8b9528 Mar 11, 2018

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 11, 2018

@imphil I am modifying the view

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 11, 2018

Would I put this view on that page
screen shot 2018-03-12 at 1 56 18 am

@sandipbhuyan sandipbhuyan force-pushed the sandipbhuyan:confirm-email-page branch from a8b9528 to 969c456 Mar 17, 2018

@imphil

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2018

@sandipbhuyan sorry for the delay. Yes, you can make use of the front-page graphics, it already provides a rather actionable starting point. But if we're going this route, why not simply redirect to the front page? What additional value can we offer to people that have just confirmed their email?

Essentially, you don't need to be logged in to download or search for a core, you also don't need to have an account to access the gitter channel, etc. The most likely option why people chose to open an account is that they want to add a new project. Maybe we can highlight this option after the email confirmation finished?

@sandipbhuyan

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 21, 2018

@imphil I think we should give a guide on how to add a project and give a navigation for redirecting to add project section

@sandipbhuyan sandipbhuyan force-pushed the sandipbhuyan:confirm-email-page branch from 969c456 to 8014cea Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.