Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a notification service #401

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@aquibbaig
Copy link
Collaborator

aquibbaig commented Aug 4, 2019

We have already bound the notificationProducer to rabbit-mq producer in services, so no need to do that now.

@aquibbaig aquibbaig force-pushed the aquibbaig:notif-producer branch from 45a04e6 to bb779c8 Aug 4, 2019
@imphil

This comment has been minimized.

Copy link
Contributor

imphil commented Aug 7, 2019

can you modify CreateNotificationCommand.php to use this new service?

@aquibbaig

This comment has been minimized.

Copy link
Collaborator Author

aquibbaig commented Aug 8, 2019

can you modify CreateNotificationCommand.php to use this new service?

Yeah sure. This will be added in this pull request

@aquibbaig aquibbaig requested a review from imphil Aug 8, 2019
@imphil
imphil approved these changes Aug 12, 2019
Copy link
Contributor

imphil left a comment

LGTM, thanks @aquibbaig!

@imphil imphil merged commit 92fa04b into librecores:master Aug 12, 2019
@aquibbaig aquibbaig added the gsoc label Aug 17, 2019
@aquibbaig aquibbaig changed the title Create a notification Create a notification service Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.