Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate project dependencies to Pipenv #1

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@jwflory
Copy link
Member

jwflory commented Nov 25, 2019

This commit reworks the project dependencies into a Pipenv-generated
Pipfile. It also specifies specific hashes and versions with the
Pipfile.lock file. This is a precursor task, leading up to more serious
Python packaging on the app. But this makes it easier for me to work on
the project, and ideally, others as well.

This commit reworks the project dependencies into a Pipenv-generated
Pipfile. It also specifies specific hashes and versions with the
Pipfile.lock file. This is a precursor task, leading up to more serious
Python packaging on the app. But this makes it easier for me to work on
the project, and ideally, others as well.
@jwflory jwflory added the enhancement label Nov 25, 2019
@jwflory jwflory requested review from Nolski and whenbellstoll Nov 25, 2019
@jwflory jwflory added this to In progress in LibreCorps operations via automation Nov 25, 2019
@Nolski

This comment has been minimized.

Copy link
Collaborator

Nolski commented Nov 25, 2019

@jwflory I know the project is pretty early stage but could you include some directions in the README.md on running with pipenv? Especially if requirements.txt is being removed.

@Nolski
Nolski approved these changes Nov 25, 2019
Copy link
Collaborator

Nolski left a comment

As per offline discussion, I'll merge this for now with the expectation that we will get around to docs later

@Nolski Nolski merged commit 0e4f3ea into master Nov 25, 2019
LibreCorps operations automation moved this from In progress to Done Nov 25, 2019
@Nolski Nolski deleted the add/pipenv branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.