Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions on readme #608

Closed
ilario opened this issue Oct 3, 2019 · 4 comments

Comments

@ilario
Copy link
Member

commented Oct 3, 2019

In the readme the suggested compilation methods are outdated.

Chef is temporarily not supporting LibreMesh.
lime-sdk is broken by various issues and core developers are not maintaining it anymore.
OpenWrt buildroot instructions should be removed and just a link to the development page on the website should be present there.

We should consider whether to add the @aparcar's metabuilder between the official compilation methods.

@bharrod321

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

I made the requested change above and have a pending pull request. This is my first time doing something like this. Please let me know if I did anything incorrect.

Thank you.

@ilario

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2019

Thanks @bharrod321!!
May I ask you the following changes?

  • lime-sdk is not recommended anymore, can you remove the phrase "either using the easy to use
    [lime-sdk][2] tool (recommended) or manually " and also the link number 2 at the bottom of the document?
  • can you remove also the whole section titled "### Using lime-sdk"?
  • in the development page on the website there are updated instructions for the build, so could you remove also the whole "### Using OpenWrt buildroot" section?
  • the link to the development page on the website, you included it in the right place, but could you include it using the syntax used for the rest of the Readme (which is: [some text bla bla bla][123] and the link at the end of the page [123]: https://libremesh.org/development.html)

Thanks again!!

bharrod321 added a commit to bharrod321/lime-packages that referenced this issue Oct 12, 2019
@bharrod321

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2019

I have created a PR with the above mentioned changes. Sorry it took so long to get back to you.

spiccinini added a commit that referenced this issue Oct 13, 2019
#608 Readme Build Removal
@ilario

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2019

#627 fixed

@ilario ilario closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.