Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency: pirania and shared-state-pirania #942

Open
ilario opened this issue Oct 25, 2022 · 0 comments
Open

Circular dependency: pirania and shared-state-pirania #942

ilario opened this issue Oct 25, 2022 · 0 comments
Assignees

Comments

@ilario
Copy link
Member

ilario commented Oct 25, 2022

The circular dependency problem is based:

  • shared-state-pirania imports voucher (from pirania package, this dependency is being added to the Makefile in Fixing some dependencies #941)
  • pirania imports shared-state (and uses it in a way that I don't understand if justifies the need for shared-state-pirania) but depends on shared-state-pirania in its Makefile

pirania uses shared-state here:

local db = shared_state.SharedStateMultiWriter:new('pirania_persistent'):get()

and here:
local db = shared_state.SharedStateMultiWriter:new('pirania_persistent')

Does this require shared-state-pirania or shared-state is enough?

If it actually require shared-state-pirania, the solution would be to merge pirania and shared-state-pirania.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants