New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create qqq language code #254

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
4 participants
@patogit
Contributor

patogit commented Nov 12, 2017

The qqq language code is for string documentation for translators. I haven't filled in the documentation messages yet.

I'm not sure if I've done the correct steps to create this pull request...?

create qqq language code
The qqq language code is for string documentation for translators. I haven't filled in the documentation messages yet.
@patogit

This comment has been minimized.

Show comment
Hide comment
@patogit

patogit Nov 12, 2017

Contributor

Also, how do you want to connect with TranslateWiki.net? Where does it make sense for TW.net to have direct push commit access: a new "translate" branch, or the "develop" branch, or somewhere else?

Contributor

patogit commented Nov 12, 2017

Also, how do you want to connect with TranslateWiki.net? Where does it make sense for TW.net to have direct push commit access: a new "translate" branch, or the "develop" branch, or somewhere else?

@ilario

This comment has been minimized.

Show comment
Hide comment
@ilario

ilario Nov 12, 2017

Member

I think the approach we discussed and was most supported was to have a separate repository for the TW direct access and merge frequently to the main one, is it correct @nicopace ?

Member

ilario commented Nov 12, 2017

I think the approach we discussed and was most supported was to have a separate repository for the TW direct access and merge frequently to the main one, is it correct @nicopace ?

@ilario ilario requested a review from nicopace Nov 12, 2017

@patogit

This comment has been minimized.

Show comment
Hide comment
@patogit

patogit Nov 12, 2017

Contributor

To see examples of how other projects on GitHub connect with Translate Wiki, look at the contribution activity of the Translate Wiki GitHub user at https://github.com/translatewiki

Contributor

patogit commented Nov 12, 2017

To see examples of how other projects on GitHub connect with Translate Wiki, look at the contribution activity of the Translate Wiki GitHub user at https://github.com/translatewiki

@patogit

This comment has been minimized.

Show comment
Hide comment
@patogit

patogit Nov 14, 2017

Contributor

@Nikerabbit from TranslateWiki.net might have ideas.

Contributor

patogit commented Nov 14, 2017

@Nikerabbit from TranslateWiki.net might have ideas.

@Nikerabbit

This comment has been minimized.

Show comment
Hide comment
@Nikerabbit

Nikerabbit Nov 14, 2017

I am not in favor of separate repositories (or separate branches) because I don't want delivery of translations to depend on human actions.
I am willing to provide some flexibility if good reasons are given (protected branches, or complex builds which may get broken by translation updates).
I also don't understand why are you creating qqq file full of TODOs. Why don't you just leave those empty so that it is clear which ones are missing.

Nikerabbit commented Nov 14, 2017

I am not in favor of separate repositories (or separate branches) because I don't want delivery of translations to depend on human actions.
I am willing to provide some flexibility if good reasons are given (protected branches, or complex builds which may get broken by translation updates).
I also don't understand why are you creating qqq file full of TODOs. Why don't you just leave those empty so that it is clear which ones are missing.

@nicopace

This comment has been minimized.

Show comment
Hide comment
@nicopace

nicopace Nov 14, 2017

Member

Hi @Nikerabbit .
This is exactly the case... we use protected branches in all repositories, so there is a pull request that needs to happen there.

Member

nicopace commented Nov 14, 2017

Hi @Nikerabbit .
This is exactly the case... we use protected branches in all repositories, so there is a pull request that needs to happen there.

@nicopace

This comment has been minimized.

Show comment
Hide comment
@nicopace

nicopace Nov 14, 2017

Member

@patogit can you change the documentation-to-do strings with empty strings as @Nikerabbit was mentioning?
Apart from that, it looks ok.

Member

nicopace commented Nov 14, 2017

@patogit can you change the documentation-to-do strings with empty strings as @Nikerabbit was mentioning?
Apart from that, it looks ok.

removed TO-DOs
this way items that are not yet done are empty instead of having a To-DO comment
@patogit

This comment has been minimized.

Show comment
Hide comment
@patogit

patogit Nov 14, 2017

Contributor

I have removed the TODOs.

Contributor

patogit commented Nov 14, 2017

I have removed the TODOs.

@nicopace nicopace merged commit e4b6544 into libremesh:develop Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patogit patogit deleted the patogit:translate/add-qqq branch Nov 15, 2017

@ilario

This comment has been minimized.

Show comment
Hide comment
@ilario

ilario Nov 15, 2017

Member

The discussion on commit access moved to #257

Member

ilario commented Nov 15, 2017

The discussion on commit access moved to #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment