Add distributed voucher system to libremesh #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G10h4ck
requested changes
Apr 16, 2019
|
|
||
| local outputLines = '' | ||
|
|
||
| function macs2string(macs) |
There was a problem hiding this comment.
have you considered table.concat ?
packages/shared-state-pirania/files/etc/shared-state/hooks/pirania/generate_vouchers
Outdated
Show resolved
Hide resolved
packages/shared-state-pirania/files/etc/shared-state/publishers/shared-state-publish_vouchers
Outdated
Show resolved
Hide resolved
aparcar
approved these changes
Apr 18, 2019
G10h4ck
requested changes
Apr 18, 2019
| return result | ||
| end | ||
|
|
||
| function macs2string(macs) |
There was a problem hiding this comment.
I meant that this whole function could be substituted by table.concat, It's me or the function is still there?
| result[voucher.voucher] = voucher | ||
| end | ||
|
|
||
| io.popen("shared-state insert pirania", "w"):write(JSON.stringify(result)) |
There was a problem hiding this comment.
Add a new line at the end of the file please
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| /etc/shared-state/publishers/shared-state-publish_vouchers | |||
| shared-state sync pirania | |||
There was a problem hiding this comment.
new line at the end of the file is missin
|
hehehe... i did the proper review... but good that u r around to catch the things you mentioned. |
|
I check if the PR possibly breaks other stuff, if not and the package doesn't concern "core" functions of LiMe I'm approving it |
G10h4ck
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me and Luandro have been working in Pirania and have built this plugin for shared-state that allows vouchers db to be shared between nodes.