Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces .lan local domain with .thisnode.info fixes #540 #541

Merged
merged 1 commit into from Nov 12, 2019

Conversation

ilario
Copy link
Member

@ilario ilario commented Jun 22, 2019

See #540

@nicopace
Copy link
Member

nicopace commented Aug 5, 2019

Why replacing it?
would suggest to add instead of replace, both can be at the same time, .lan is short (but requires to write the whole http://site.lan/ url), and the other one is longer but proper without the http:// part, so we should leave both.

@ilario
Copy link
Member Author

ilario commented Aug 5, 2019

would suggest to add instead of replace, both can be at the same time

I didn't know it was possible. @nicopace how do you set it up in OpenWrt?

@nicopace
Copy link
Member

nicopace commented Aug 5, 2019

Don't know how...

This is another approach: https://web.archive.org/web/20180722223228/https://iyware.com/dont-use-dev-for-development/
like the .localhost subdomain as it is saying is a local host (local for the network) , and is a valid domain!

@ilario
Copy link
Member Author

ilario commented Aug 5, 2019

.lan is short

Consider that even if we replace .lan with .thisnode.info, the nodes will be accessible BOTH with http://lime-ddeeff.thisnode.info and with http://lime-ddeeff
so, if someone prefers to write less, it can already avoid writing the domain name.

@nicopace
Copy link
Member

nicopace commented Aug 5, 2019

Well.. it looks it is not possible to define two domains (at least not in a fast search, because that "domain" key is also used to tell DHCP clients in which domain they are at.

This is another approach: https://web.archive.org/web/20180722223228/https://iyware.com/dont-use-dev-for-development/

Based on that document that I shared earlier, to be standards compliant we can use the *.thisnode.info, or the *.localhost domains.

On the other hand, using *.thisnode.info allows us to capture when the users are using the domain outside their network (like through their mobile network when it exists), and help them through it...

@spiccinini spiccinini self-requested a review November 12, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants