Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unittesting P6] Add fake device support and lime-config test #567

Merged

Conversation

@spiccinini
Copy link
Contributor

commented Aug 24, 2019

Adds fake devices support, starting with LibreRouter-v1. This devices is used to perform an integation test running the main part of lime-config with this fakes device

Should be applied after P5 (#566 ).
Hint: easer review doing commit by commit.

@@ -0,0 +1,53 @@
{

This comment has been minimized.

Copy link
@nicopace

nicopace Aug 25, 2019

Member

isn't this file available somewhere already? can find the same one in the /etc/board.json of the librerouters...

This comment has been minimized.

Copy link
@spiccinini

spiccinini Aug 29, 2019

Author Contributor

This files is created on first boot by /bin/board_detect that I think is run by /etc/preinit that is run by procd. /etc/board.json is created with information gathered mostly by /etc/board.d/02_network so the way the information is stored on the code is in bash form.

This comment has been minimized.

Copy link
@nicopace

nicopace Aug 29, 2019

Member

So we can't get it from there for the tests then? (just thinking on deduplicating it because of the implications on maintenance...)

This comment has been minimized.

Copy link
@spiccinini

spiccinini Aug 30, 2019

Author Contributor

I am not sure to be understanding your question. You mean from inside a LinbreRouter? Yes that is what I did (I copied the board.json file and the other two files, network and wireless) and that is what I think we should do for other devices too. I don't think there is an online database of this files so we don't have to do it. If we want to have this kind of integration test "with device emulation" then I don't think we have other options, or maybe I am not seeing it?

This comment has been minimized.

Copy link
@nicopace

nicopace Sep 1, 2019

Member

I mean getting that information from where it comes instead of hardcoding it...
don't worry, it is a lower priority thing. important to keep an eye on deduplication, but certainly not urgent

tests/test_iwinfo.lua Outdated Show resolved Hide resolved

@spiccinini spiccinini changed the base branch from master to fix/bat-hosts Sep 2, 2019

@spiccinini spiccinini changed the base branch from fix/bat-hosts to master Sep 2, 2019

@gmarcos87 gmarcos87 self-requested a review Sep 2, 2019

@gmarcos87 gmarcos87 merged commit 61d2885 into libremesh:master Sep 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.