Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved udhcpc.user file to installer script #928

Closed
wants to merge 2 commits into from

Conversation

@codecov-commenter
Copy link

Codecov Report

Merging #928 (18c2ff3) into master (5377f5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files          48       48           
  Lines        4074     4074           
=======================================
  Hits         3126     3126           
  Misses        948      948           
Impacted Files Coverage Δ
packages/pirania/tests/pirania_test_utils.lua 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ilario
Copy link
Member Author

ilario commented Jul 27, 2022

To me it does not look like there is any need to update the tests, is this correct @spiccinini?

@G10h4ck
Copy link
Member

G10h4ck commented Nov 28, 2022

@ilario see my coments at #927

@ilario
Copy link
Member Author

ilario commented Nov 29, 2022

Just tested this PR and it is broken.
@G10h4ck pointed out that we could use the /etc/udhcpc.user.d/ directory and place stuff in there. This way is much better so I am going to close this PR.
The doubt is whether that directory will work also on OpenWrt 19.07. To be tested.

@ilario ilario closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ubus-lime-utils file conflict when compiling with OpenWrt 22.03
3 participants