Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some dependencies #941

Merged
merged 57 commits into from Nov 29, 2022
Merged

Fixing some dependencies #941

merged 57 commits into from Nov 29, 2022

Conversation

ilario
Copy link
Member

@ilario ilario commented Oct 19, 2022

As indicated in #940, I just realized that some dependencies are missing.
Here go some fixes, more will be added to this PR, please do not merge yet.

…/libexec/rpcd/lime-groundrouting and contained in luci-compat
…les/usr/lib/lua/prometheus-collectors/location_latlon.lua
…a/files/usr/lib/lua/prometheus-collectors/wifi_stations_extra.lua
…usr/lib/lua/prometheus-collectors/wifi_survey.lua
…hooks/pirania-vouchers/generate_vouchers and contained in pirania
…an-ok.d/babeld-gw and contained in lime-system
…b/lua/luci/controller/openairview.lua and contained in luci-compat
…/luci/controller/status/switch.lua and contained in luci-compat
@ilario ilario marked this pull request as ready for review October 24, 2022 17:39
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #941 (b1fd901) into master (6366d09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files          48       48           
  Lines        4174     4174           
=======================================
  Hits         3254     3254           
  Misses        920      920           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ilario
Copy link
Member Author

ilario commented Oct 24, 2022

My personal dependencies crusade is over, I am not sure I fixed everything (e.g. luci.tools stuff I didn't check where it is).
Just checked with the buildroot of OpenWrt 22.03 and no additional warning (the ones from libremap are still there, see #929) appears, so it should be ok to merge.
I didn't check with OpenWrt 19.07 but none of the packages mentioned as dependencies should have been renamed since 2019.

@ilario
Copy link
Member Author

ilario commented Oct 25, 2022

One doubt: the luci-lib-json dependency has not been updated to luci-lib-jsonc for luci-mod-status and luci-app-openairview. I don't know if these two packages would work also with jsonC.

@ilario
Copy link
Member Author

ilario commented Oct 25, 2022

Just checked with the buildroot of OpenWrt 22.03 and no additional warning (the ones from libremap are still there, see #929) appears, so it should be ok to merge. I didn't check with OpenWrt 19.07 but none of the packages mentioned as dependencies should have been renamed since 2019.

Correction: there IS a new warning.

tmp/.config-package.in:101823:error: recursive dependency detected!
tmp/.config-package.in:101823:	symbol PACKAGE_pirania is selected by PACKAGE_shared-state-pirania
tmp/.config-package.in:60861:	symbol PACKAGE_shared-state-pirania is selected by PACKAGE_pirania
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

I confirmed with OpenWrt 19.07 and this is the only new warning that appears with both 22.03 and 19.07.

Reported as a separate issue on #942

@ilario ilario merged commit 626e8b3 into libremesh:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants