Samsung Printer OS Discovery #4251

Closed
osiktech opened this Issue Aug 29, 2016 · 0 comments

Projects

None yet

1 participant

@osiktech
osiktech commented Aug 29, 2016 edited

Hi everybody,

it seems there is an error in includes/discovery/os/samsungprinter.inc.php

<?php
if (!$os) {
if (strstr($sysDescr, 'Samsung CLX') ||
strstr($sysDescr, 'Samsung SCX') ||
strstr($sysDescr, 'Samsung C') ||
strstr($sysDescr, 'Samsun C')) {
$os = 'samsungprinter';
}
}

not sure if strstr($sysDescr, 'Samsun C') is intentential but it leads into problemw with the discovery of some of my printers, thats why I manually added strstr($sysDescr, 'Samsung C') || the line before.

I also added strstr($sysDescr, 'Samsung S') ||

After I did this my printers where no longer generic but samsung printers.

Best

@Rosiak Rosiak added a commit to Rosiak/librenms that referenced this issue Aug 29, 2016
@Rosiak Rosiak fix: Samsung Printer Discovery #4251 ac8f923
@Rosiak Rosiak referenced this issue Aug 29, 2016
Merged

fix: Samsung Printer Discovery #4251 #4258

2 of 2 tasks complete
@laf laf closed this in #4258 Aug 29, 2016
@laf laf added a commit that referenced this issue Aug 29, 2016
@Rosiak @laf Rosiak + laf fix: Samsung Printer Discovery #4251 (#4258)
* fix: Samsung Printer Discovery #4251
5cff81b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment