Not all dnos dell N2000/3000/4000 are supported #4627

Closed
zamolxe opened this Issue Sep 27, 2016 · 5 comments

Projects

None yet

5 participants

@zamolxe
zamolxe commented Sep 27, 2016

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

  • Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • Please include all of the information between the ==================================== section of ./validate.php.
  • If you would like us to add a new device then please provide the information asked for here
  • Please provide as much detail as possible.

Some of the Dell N2000/3000/4000 are missing
Below is the complete includes/discovery/os/dnos.inc.php build based on the oids provided by dell openmanage
OpenManage Network Manager 6 Device Drivers and OSs Supported.pdf

<?php

if (!$os) {
    if (strstr($sysObjectId, '.1.3.6.1.4.1.6027.1.')) {
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3042')) {  // N4032
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3044')) {  // N4032F
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3045')) {  // N4064
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3046')) {  // N4064F
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3053')) {  // N2024
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3054')) {  // N2048
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3055')) {  // N2024P
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3056')) {  // N2048P
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3057')) {  // N3024
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3058')) {  // N3048P
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3059')) {  // N3024P
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3060')) {  // N3024P
        $os = 'dnos';
    }
    if (strstr($sysObjectId, '.1.3.6.1.4.1.674.10895.3061')) {  // N3024F
        $os = 'dnos';
    }
}

/Alex

@cschoonover91
Contributor

@laf has a PR out on refactoring this (#4572). Based on his work, the provided code is out of date. May need to wait until the PR is merged before adding the new OIDs into the array.

@zamolxe
zamolxe commented Sep 27, 2016

No worries, I've been running my version of file for about 1year, never had the time to actually request and update here until now.
Thanks!

@Rosiak Rosiak added a commit to Rosiak/librenms that referenced this issue Oct 1, 2016
@Rosiak Rosiak newdevice: Add support for more DNOS devices #4627 673647b
@murrant
Contributor
murrant commented Oct 1, 2016 edited

Any reason we can' t just check for .1.3.6.1.4.1.674.10895 or even .1.3.6.1.4.1.674.10895.30

@laf laf added the New-Device label Oct 5, 2016
@laf
Member
laf commented Oct 5, 2016

Powerconnect has .1.3.6.1.4.1.674.10895.3000.1.2.100.1.0 which would also match those. We could just exclude those but we can't be sure we won't impact something else.

@BryannaM
BryannaM commented Oct 6, 2016

Just to add to this we have a Dell N1548P and it is not detected and it has a different ObjectID then even the ones asked to be added. I attached a screenshot to show this.
2016-10-06_10h17_57

@laf laf closed this in #4687 Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment