New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML support is broken in Notes Widget #4898

Closed
vitalisator opened this Issue Oct 29, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@vitalisator
Contributor

vitalisator commented Oct 29, 2016

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

  • [ x ] Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • [ x ] Please include all of the information between the ==================================== section of ./validate.php.
  • If you would like us to add a new device then please provide the information asked for here
  • [ x ] Please provide as much detail as possible.

LibreNMS Version: b89ebab
DB Schema: 148
PHP: 5.6.24-0+deb8u1
MySQL: 5.5.52-0+deb8u1
RRDTool: 1.4.8
SNMP: NET-SNMP 5.7.2.1

Since 2-3 weeks notes widget show html as text.
Is something changed here?

https://snag.gy/G7PLz3.jpg

@laf

This comment has been minimized.

Member

laf commented Nov 3, 2016

This was from a security update we did that now strips out html tags. Will have to work some of allowing that but not <script> tags

@f0o

This comment has been minimized.

Member

f0o commented Nov 3, 2016

Maybe we can implement markdown or other formating engines to avoid raw HTML. This might even come handy for alerting :D

@laf laf added the Bug 🐞 label Nov 17, 2016

@laf laf closed this in #5006 Nov 26, 2016

laf added a commit that referenced this issue Nov 26, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.