New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireless Access Point -> Wireless Type? #5254

Closed
arrmo opened this Issue Dec 27, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@arrmo
Contributor

arrmo commented Dec 27, 2016

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

GitHub issues is for feature requests or bugs, please do not post issues asking for help or how to do X, Y or Z.
You can use our irc channel ##librenms on freenode to ask questions or our community site.

  • [X ] Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • [ X] Please include all of the information between the ==================================== section of ./validate.php.
  • [ X] If you would like us to add a new device or your device is listed as Generic then please provide the information asked for here
  • [ X] Please provide as much detail as possible.

Hi,

I know I can manually change this (1-by-1), but thinking there should be a better way (and there likely is). For WAP's running, for example, OpenWRT, DD-WRT, ASUSWRT-Merlin, Tomato, etc. ... because they run Linux they show up as a device type of "server" (based on Operating System) - but perhaps based on Platform they could / should be categorized as a device type of "Wireless"?

Thoughts?

I'm fine changing this in the code to help out, just can't figure out what / where to change it ... :(.

Thanks!

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Dec 27, 2016

Member

If we have a way to detect these devices then we should - we'd need the output of the info asked for in point 3 above.

Member

laf commented Dec 27, 2016

If we have a way to detect these devices then we should - we'd need the output of the info asked for in point 3 above.

@laf laf added the Needs-Info label Dec 27, 2016

@arrmo

This comment has been minimized.

Show comment
Hide comment
@arrmo

arrmo Dec 28, 2016

Contributor

Sure, NP! Files attached - for the three commands (discovery, poller and snmpbulkwalk), for both ASUSWRT-Merlin and Tomato. I don't have DD-WRT (that router died), and OpenWRT (not using it) - but start with these two at least? And - perhaps use the output of distro?

Thanks!

discovery.ASUSWRT-Merlin.txt
discovery.Tomato.txt
poller.ASUSWRT-Merlin.txt
poller.Tomato.txt
snmpbulkwalk.ASUSWRT-Merlin.txt
snmpbulkwalk.Tomato.txt

Contributor

arrmo commented Dec 28, 2016

Sure, NP! Files attached - for the three commands (discovery, poller and snmpbulkwalk), for both ASUSWRT-Merlin and Tomato. I don't have DD-WRT (that router died), and OpenWRT (not using it) - but start with these two at least? And - perhaps use the output of distro?

Thanks!

discovery.ASUSWRT-Merlin.txt
discovery.Tomato.txt
poller.ASUSWRT-Merlin.txt
poller.Tomato.txt
snmpbulkwalk.ASUSWRT-Merlin.txt
snmpbulkwalk.Tomato.txt

@laf laf added Device 🖥 and removed Needs-Info labels Dec 28, 2016

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Dec 28, 2016

Contributor

Well, running those OS'es does not immediately mean, they are always running as AP's and in case of OpenWRT, it does not even mean it always even has Wireless.
Also you can run OpenWRT as NAS software or as plain simple Firewall if you wish, without any wireless hardware even present.

AsusWRT has also multiple operating modes, Router/AP/Media Bridge/etc.. , so running AsusWRT does not always mean that it runs as Wireless AP.

In summary, IMHO only device operator knows exactly in what mode those devices are run, so I don't think that identifying them all as "Wireless" is an good idea. They should be rather categorized as "Network" as they all are mostly used as Network device OS'es.

Anyway, I can do some OpenWRT dumps if necessary on 2 different devices.
(One is Turris Omnia and other is Inteno).

Unfortunately I cannot help with DD-WRT, as I have no devices for running it.

Contributor

E-t-z commented Dec 28, 2016

Well, running those OS'es does not immediately mean, they are always running as AP's and in case of OpenWRT, it does not even mean it always even has Wireless.
Also you can run OpenWRT as NAS software or as plain simple Firewall if you wish, without any wireless hardware even present.

AsusWRT has also multiple operating modes, Router/AP/Media Bridge/etc.. , so running AsusWRT does not always mean that it runs as Wireless AP.

In summary, IMHO only device operator knows exactly in what mode those devices are run, so I don't think that identifying them all as "Wireless" is an good idea. They should be rather categorized as "Network" as they all are mostly used as Network device OS'es.

Anyway, I can do some OpenWRT dumps if necessary on 2 different devices.
(One is Turris Omnia and other is Inteno).

Unfortunately I cannot help with DD-WRT, as I have no devices for running it.

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Dec 28, 2016

Contributor

OpenWRT (Inteno DG301A)

http://etz.planet.ee/Inteno-OpenWRT-poller.txt
http://etz.planet.ee/Inteno-OpenWRT-discovery.txt
http://etz.planet.ee/Inteno-OpenWRT-bulkwalk.txt

Will do, Turris Omnia run later, as I first have plug it in and re-add it to LibreNMS.

Contributor

E-t-z commented Dec 28, 2016

OpenWRT (Inteno DG301A)

http://etz.planet.ee/Inteno-OpenWRT-poller.txt
http://etz.planet.ee/Inteno-OpenWRT-discovery.txt
http://etz.planet.ee/Inteno-OpenWRT-bulkwalk.txt

Will do, Turris Omnia run later, as I first have plug it in and re-add it to LibreNMS.

@arrmo

This comment has been minimized.

Show comment
Hide comment
@arrmo

arrmo Dec 28, 2016

Contributor

Hi,

No issues here using Network rather than Wireless - agree with your point above. Right now they show up as Server, not sure that's the right selection ... ;).

Thanks!

Contributor

arrmo commented Dec 28, 2016

Hi,

No issues here using Network rather than Wireless - agree with your point above. Right now they show up as Server, not sure that's the right selection ... ;).

Thanks!

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Dec 28, 2016

Contributor

As promised earlier, from OpenWRT on Turris Omnia:

http://etz.planet.ee/Turris-OpenWRT-poller.txt
http://etz.planet.ee/Turris-OpenWRT-discovery.txt
http://etz.planet.ee/Turris-OpenWRT-bulkwalk.txt

Currently testing it, will replace that Inteno once I have fed up with playing around with it.
It is currently most powerful OpenWRT based router on the market with open hardware. 👍

Contributor

E-t-z commented Dec 28, 2016

As promised earlier, from OpenWRT on Turris Omnia:

http://etz.planet.ee/Turris-OpenWRT-poller.txt
http://etz.planet.ee/Turris-OpenWRT-discovery.txt
http://etz.planet.ee/Turris-OpenWRT-bulkwalk.txt

Currently testing it, will replace that Inteno once I have fed up with playing around with it.
It is currently most powerful OpenWRT based router on the market with open hardware. 👍

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Dec 28, 2016

Contributor

About DD-WRT I only found this: https://www.dd-wrt.com/wiki/index.php/SNMP#Known_OID.C2.B4s_via_SNMP

As I have 0 devices with it, cannot unfortunately help with anything else...

Contributor

E-t-z commented Dec 28, 2016

About DD-WRT I only found this: https://www.dd-wrt.com/wiki/index.php/SNMP#Known_OID.C2.B4s_via_SNMP

As I have 0 devices with it, cannot unfortunately help with anything else...

laf added a commit to laf/librenms that referenced this issue Jan 11, 2017

@laf laf referenced this issue Jan 11, 2017

Merged

newdevice: Added Tomato and AsusWRT-Merlin OS #5254 #5398

2 of 2 tasks complete
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 11, 2017

Member

I actually think a lot of these are taken care of if you install the distro script from the librenms-agent repo. However I've added detection for Tomato and AsusWRT-Merlin as we can detect those natively. The others don't appear to offer anyway to do so via snmp.

Member

laf commented Jan 11, 2017

I actually think a lot of these are taken care of if you install the distro script from the librenms-agent repo. However I've added detection for Tomato and AsusWRT-Merlin as we can detect those natively. The others don't appear to offer anyway to do so via snmp.

@arrmo

This comment has been minimized.

Show comment
Hide comment
@arrmo

arrmo Jan 12, 2017

Contributor

Thanks! Will give it a try once this is merged - much appreciated.

FYI, I do have the distro script installed (Tomato at least).

Contributor

arrmo commented Jan 12, 2017

Thanks! Will give it a try once this is merged - much appreciated.

FYI, I do have the distro script installed (Tomato at least).

@murrant murrant closed this in #5398 Jan 13, 2017

murrant added a commit that referenced this issue Jan 13, 2017

newdevice: Added Tomato and AsusWRT-Merlin OS #5254 (#5398)
* newdevice: Added Tomato and AsusWRT-Merlin OS #5254

* that should not be there
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.