device type not being set for any new devices #5412

Closed
sysmonk opened this Issue Jan 12, 2017 · 2 comments

Projects

None yet

2 participants

@sysmonk
Contributor
sysmonk commented Jan 12, 2017

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

GitHub issues is for feature requests or bugs, please do not post issues asking for help or how to do X, Y or Z.
You can use our irc channel ##librenms on freenode to ask questions or our community site.

Please confirm each of the sections below by putting an x in the box like [x].

  • Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • Please include all of the information between the ==================================== section of ./validate.php which you can run from the cli.
  • Unless your issue is for a WebUI fix or feature then please provide ALL info asked for here.
  • Please provide as much detail as possible.
==========================================================Component Version
LibreNMS 78cdca0
DB Schema 153
PHP 7.0.14-1~dotdeb+8.1
MySQL 10.0.28-MariaDB-0+deb8u1
RRDTool 1.4.8
SNMP NET-SNMP 5.7.2.1
==========================================================

Librenms stopped setting the device type for new devices added recently. This sounds related to https://github.com/librenms/librenms/blob/master/includes/common.php#L1529 - it's sets the type (and makes any later checks not see that it changed), but does not update the db.

@laf
Member
laf commented Jan 12, 2017

The type setting isnt done there. It's done here. https://github.com/librenms/librenms/blob/master/includes/discovery/os.inc.php

Please post output onto pastebin for ./discovery.php -h HOSTNAME -d -m os

@laf
Member
laf commented Jan 12, 2017

Actually don't need this, confirmed, fix being done.

@laf laf added a commit to laf/librenms that referenced this issue Jan 12, 2017
@laf laf fix: Detection blank or unknown device types and update #5412 dc0b83e
@murrant murrant closed this in #5414 Jan 13, 2017
@murrant murrant added a commit that referenced this issue Jan 13, 2017
@laf @murrant laf + murrant fix: Detection blank or unknown device types and update #5412 (#5414)
* fix: Detection blank or unknown device types and update #5412

* Less ifs
6ff3ae8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment