graph wifi clients for Deliberant DLB APC Button, DLB APC Button AF and DLB APC 2Mi #5456

Closed
sysmonk opened this Issue Jan 16, 2017 · 1 comment

Projects

None yet

2 participants

@sysmonk
Contributor
sysmonk commented Jan 16, 2017

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

GitHub issues is for feature requests or bugs, please do not post issues asking for help or how to do X, Y or Z.
You can use our irc channel ##librenms on freenode to ask questions or our community site.

Please confirm each of the sections below by putting an x in the box like [x].

  • Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • Please include all of the information between the ==================================== section of ./validate.php which you can run from the cli.
  • Unless your issue is for a WebUI fix or feature then please provide ALL info asked for here.
  • Please provide as much detail as possible.
==========================================================Component Version
LibreNMS 44071e8
DB Schema 154
PHP 7.0.14-1~dotdeb+8.1
MySQL 10.0.28-MariaDB-0+deb8u1
RRDTool 1.4.8
SNMP NET-SNMP 5.7.2.1
==========================================================

Can we please get wifi clients graphed for Deliberant DLB APC Button, DLB APC Button AF and DLB APC 2mi?

Something like this should be enough:

index 94a29df..c6be7c9 100644
--- a/includes/polling/wifi.inc.php
+++ b/includes/polling/wifi.inc.php
@@ -88,6 +88,14 @@ if ($device['type'] == 'network' || $device['type'] == 'firewall' || $device['ty
             echo "AP does not supply client counts\n";
         }
         include 'includes/polling/mib/ubnt-unifi-mib.inc.php';
+    } elseif  ($device['os'] == 'deliberant' && str_contains($device['hardware'], "DLB APC Button")) {
+        echo 'Checking Deliberant APC Button wireless clients... ';
+        $wificlients1 = snmp_get($device, '.1.3.6.1.4.1.32761.3.5.1.2.1.1.16.7', '-OUqnv');
+        echo $wificlients1." clients\n";
+    } elseif  ($device['os'] == 'deliberant' && $device['hardware'] == "\"DLB APC 2Mi\"") {
+        echo 'Checking Deliberant APC 2Mi wireless clients... ';
+        $wificlients1 = snmp_get($device, '.1.3.6.1.4.1.32761.3.5.1.2.1.1.16.5', '-OUqnv');
+        echo $wificlients1." clients\n";
     }
 
     // Loop through all $wificlients# and data_update()

I'm running this code for a few days now, everything looks ok.

@laf
Member
laf commented Jan 16, 2017

Please submit this code in a pull request, we can't accept the code until you sign the contributors agreement and then submit the pull request.

@laf laf added a commit that referenced this issue Jan 16, 2017
@sysmonk @laf sysmonk + laf newdevice: Add wifi clients for Deliberant DLB APC Button, DLB APC Bu…
…tton AF and DLB APC 2mi #5456
463b271
@laf laf closed this Jan 16, 2017
@laf laf added a commit to InsaneSplash/librenms that referenced this issue Jan 21, 2017
@InsaneSplash @laf InsaneSplash + laf # This is a combination of 17 commits.
# The first commit's message is:
I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.

# This is the 2nd commit message:

Fixed error in pseudowires.inc.php files

# This is the 3rd commit message:

Change the colour of the port icon

# This is the 4th commit message:

Revert "Fixed error in pseudowires.inc.php files"

This reverts commit f64cb07.

# This is the 5th commit message:

Fixed error in pseudowires.inc.php files

# This is the 6th commit message:

Revised the primary menu to try standardise icons and layout. Fixed icon size for countdown_timer icons.

# This is the 7th commit message:

Fixed formatting non-compliance testing

# This is the 8th commit message:

Updated additional icons and adjusted to meet the new standard as per menu bar

# This is the 9th commit message:

found a few more lurkers

# This is the 10th commit message:

webui: Update add/edit user page to use their instead of his #5457 (#5460)

# This is the 11th commit message:

newdevice: Add wifi clients for Deliberant DLB APC Button, DLB APC Button AF and DLB APC 2mi #5456

# This is the 12th commit message:

various small doc improvements (#5459)

# This is the 13th commit message:

newdevice: Added CPU support for Edge Core OS

# This is the 14th commit message:

newdevice: Added support for CTC Union devices (#5402)

* newdevice: Added support for CTC Union devices

* added logo

* added unit test

* added missing snmprec file

* replaced logo

* reverted logo

* and again :/

# This is the 15th commit message:

fix: validate suid is set for fping (#5474)

# This is the 16th commit message:

fix as reported by @Compizfox (#5473)

# This is the 17th commit message:

fix: Updated prestiage detection #5453 (#5470)
54847f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment