New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function name conflict rrd_info() #5478

Closed
julienmorot opened this Issue Jan 16, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@julienmorot

julienmorot commented Jan 16, 2017

Hello team,

Collectd plugin is not working with master, access to collectd tabs gives an apache error 500 in access log file :
"GET /device/device=30/tab=collectd/ HTTP/1.1" 500 5951

With PHP debug enabled, I can see the following error :
PHP Fatal error: Cannot redeclare rrd_info() in /opt/librenms/html/includes/collectd/functions.php on line 448

sed -i 's/rrd_info/myrrd_info' /opt/librenms/html/includes/collectd/functions.php solved the problem because rrd_info is already part of php-rrd package :
http://php.net/rrd_info

Thanks,

Julien Morot

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 16, 2017

Member

I'd suggest you remove the php-rrd package, we don't use it or rely on it in anyway.

Member

laf commented Jan 16, 2017

I'd suggest you remove the php-rrd package, we don't use it or rely on it in anyway.

@julienmorot

This comment has been minimized.

Show comment
Hide comment
@julienmorot

julienmorot Jan 17, 2017

I can't and probably others users won't be able too.
We rely on php-gd for cacti and probably other users are using different application on the same system (pnp4nagios, etc...) and can't remove php-gd.

julienmorot commented Jan 17, 2017

I can't and probably others users won't be able too.
We rely on php-gd for cacti and probably other users are using different application on the same system (pnp4nagios, etc...) and can't remove php-gd.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 17, 2017

Member

php-gd, you said php-rrd earlier?

Member

laf commented Jan 17, 2017

php-gd, you said php-rrd earlier?

@julienmorot

This comment has been minimized.

Show comment
Hide comment
@julienmorot

julienmorot Jan 17, 2017

Your're right, I didn't took my coffee! It's php-rrd of course ;)

julienmorot commented Jan 17, 2017

Your're right, I didn't took my coffee! It's php-rrd of course ;)

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 17, 2017

Member

So this can be closed?

Member

laf commented Jan 17, 2017

So this can be closed?

@julienmorot

This comment has been minimized.

Show comment
Hide comment
@julienmorot

julienmorot Jan 17, 2017

It can't be closed. Librenms collectd feature should work as if php-rrd is installed on the system.
The fix is easy, just one function rename and one function call to adapt, nothing that could lead to a regression. Please consider fixing it.

julienmorot commented Jan 17, 2017

It can't be closed. Librenms collectd feature should work as if php-rrd is installed on the system.
The fix is easy, just one function rename and one function call to adapt, nothing that could lead to a regression. Please consider fixing it.

@sorano

This comment has been minimized.

Show comment
Hide comment
@sorano

sorano Jan 18, 2017

Contributor

Then why not submit the fix yourself if it's that easy?

Contributor

sorano commented Jan 18, 2017

Then why not submit the fix yourself if it's that easy?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jan 28, 2017

Member

I've submitted a fix for this. This is an upstream issue and we can't offer any guarantees that the file won't be updated in the future and break again.

Member

laf commented Jan 28, 2017

I've submitted a fix for this. This is an upstream issue and we can't offer any guarantees that the file won't be updated in the future and break again.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.