Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Service module has conflicted configuration files #5903
Service module has conflicted configuration files
I noticed that the service module has some conflict in the files that make some variables to be ignored. To explain my problem, we're using this example only the Nagios check_http module.
When configuring LibreNMS to check a service that's NOT linked to a device, I noticed that the field "IP Address" is ignored with the check_http module and not with the check_ldap module.
Browsing the source code to understand my problem I noticed this problem:
So the question is why using custom files for services that's compatible with the "standard" method present on line 128 using the -H argument? This is redundant?
To correct this problem we need to implement the $ip variable to all the files in librenms/includes/services/ or to remove the files that use exactly the same format at the line 128 I think. If technically there is no reason to use a separated file, I prefer the second method.
Perhaps @adaniels21487 can help for this?
referenced this issue
Feb 17, 2017
Sorry, I'm a little late to the party...