Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alert-Groups. #616

Closed
f0o opened this issue Mar 18, 2015 · 12 comments
Closed

Add Alert-Groups. #616

f0o opened this issue Mar 18, 2015 · 12 comments
Assignees

Comments

@f0o
Copy link
Member

f0o commented Mar 18, 2015

Manage alerts to be run on a group of heterogene devices. Such as DC, CustA, ClusterA,...

This will require a Page that manages devices into Alert-Groups and a new notation for Alert-Rules to indicate a single target, a global target or a group target.

@f0o f0o self-assigned this Mar 18, 2015
@paulgear
Copy link
Member

Sounds like a good idea to me

@Alastair-VOIPUNLIMITED
Copy link

Definitely, especially when you are attempting to monitor a large number of nodes in groups, are there any updates on this feature? We are keen to start testing :)

Thank you

Alastair

@f0o
Copy link
Member Author

f0o commented Mar 24, 2015

it's on top of my todo-list :)

I cant give a specific ETA as my work-schedule is a bit 'on-call'-heavy currently...
However, I got a very early draft running and am just fiddling around the DB-notation for the rules.

What I didnt bother doing so far is the GUI, I suggest a simple multi-select-box with a name... but I'm absolutely not a GUI-maker haha - feel free to suggest something better.

@laf
Copy link
Member

laf commented Mar 24, 2015

Happy to pick up the GUI parts as always @f0o. If you give me an idea on how it works and the db schema updates I'll work on something to coincide with you releasing the back end update.

@Alastair-VOIPUNLIMITED
Copy link

thank you for such a quick response, and for the work done already!

Would that be as a drop down? you could always do it the same way observium did, which is to rely on the user putting in that metric themselves. (screenshot attached)

capture1112

please bear in mind that our "types" are added ones from us on the back end so we could do it this way, would it would be possible for a GUI way to add "device types" too? instead of auto detection?

Thank you

Alastair

@laf
Copy link
Member

laf commented Mar 24, 2015

We're open to suggestions on how to do the UI (or have a go at it yourself if you like :))

As for setting your own device types, from looking at the code we would allow users to break things by doing that (for instance certain polling functions check the device type so if this was no longer set to what was expected then polling wouldn't run).

That doesn't mean we couldn't allow someone to set a secondary device type - @f0o how would that work with your idea for groups?

Alternatively you can set a custom description already per device. You could set the device type you want there then use that in the alerts system.

@Alastair-VOIPUNLIMITED
Copy link

unfortunately we don't have anybody with experience with UI design, however I believe a few members of the team are quite keen to share various mySQL tweaks and changes that they made on our version of observium if they are applicable to librenms :)

Thank you

Alastair

@laf
Copy link
Member

laf commented Mar 24, 2015

@Alastair-VOIPUNLIMITED No probs on the UI side - I end up doing a lot of that anyway so we're covered :)

Would love to see the tweaks they've made, we're a little bit different now on MySQL schema but a large % still remains the same.

Is the API of any use to you? If so and it's missing anything then let me know so I can add it in.

@Alastair-VOIPUNLIMITED
Copy link

That would be fantastic! Would mean a lot fewer alarm checkers!!

Sent from Ninehttp://www.9folders.com/

From: Daniel Preussker notifications@github.com
Sent: 2 Apr 2015 18:22
To: librenms/librenms
Cc: Alastair Chamorro
Subject: Re: [librenms] Add Alert-Groups. (#616)

@Alastair-VOIPUNLIMITEDhttps://github.com/Alastair-VOIPUNLIMITED do you want a rule to be processed for several groups?

Current PR only covers 1 Group per Rule and N Groups per Device.


Reply to this email directly or view it on GitHubhttps://github.com//issues/616#issuecomment-88979642.

The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system.

@f0o
Copy link
Member Author

f0o commented Apr 2, 2015

Cheers @Alastair-VOIPUNLIMITED, we just discussed the issue on IRC and came to the conclusion that a different approach will be better.

sadly I've to postpone this feature again, I will try to get a draft done by today but most of the day has already passed :/

@Alastair-VOIPUNLIMITED
Copy link

Hey team,

That's perfectly fine, we are not in the office until next Tuesday anyway. Thank you for your time on this :)

When we start implementing it ourselves we will no doubt have things to contribute too.

Alastair

Sent from Ninehttp://www.9folders.com/

From: Daniel Preussker notifications@github.com
Sent: 2 Apr 2015 18:45
To: librenms/librenms
Cc: Alastair Chamorro
Subject: Re: [librenms] Add Alert-Groups. (#616)

Cheers @Alastair-VOIPUNLIMITEDhttps://github.com/Alastair-VOIPUNLIMITED, we just discussed the issue on IRC and came to the conclusion that a different approach will be better.

sadly I've to postpone this feature again, I will try to get a draft done by today but most of the day has already passed :/


Reply to this email directly or view it on GitHubhttps://github.com//issues/616#issuecomment-88988220.

The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system.

@f0o
Copy link
Member Author

f0o commented Apr 4, 2015

@Alastair-VOIPUNLIMITED We've merged Device-Groups now, These can be mapped to alerts.

Please update your install and check out #722 for details, Or come to IRC if you got questions :)

@f0o f0o closed this as completed Apr 4, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants