New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable 95th percentile #7406

Closed
laf opened this Issue Sep 29, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@laf
Member

laf commented Sep 29, 2017

https://community.librenms.org/t/98th-percentile-graphs/2231

This should be a simple case of replacing all occurrences of 95,PERCENT in html/includes/graphs/ with a user configurable config option like $config['percentile_value'] and adding it to doc/Support/Configuration.md

@yunchih

This comment has been minimized.

Show comment
Hide comment
@yunchih

yunchih Sep 30, 2017

Contributor

Hi, I can try taking this.

Contributor

yunchih commented Sep 30, 2017

Hi, I can try taking this.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Oct 1, 2017

Member

Thanks. Give us a shout if you need any help

Member

laf commented Oct 1, 2017

Thanks. Give us a shout if you need any help

@yunchih

This comment has been minimized.

Show comment
Hide comment
@yunchih

yunchih Oct 6, 2017

Contributor

95,PERCENT is always accompanied by a label, like the 95thin in:

html/includes/graphs/generic_multi_bits.inc.php, 56:
$rrd_options .= ' VDEF:95thin=inbits,95,PERCENT';

Shall we rename those labels to percent_thin, percent_thout, etc? Or just keep it as it is and replace 95,PERCENT only?

Contributor

yunchih commented Oct 6, 2017

95,PERCENT is always accompanied by a label, like the 95thin in:

html/includes/graphs/generic_multi_bits.inc.php, 56:
$rrd_options .= ' VDEF:95thin=inbits,95,PERCENT';

Shall we rename those labels to percent_thin, percent_thout, etc? Or just keep it as it is and replace 95,PERCENT only?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Oct 6, 2017

Member

You could change the labels to be more consistent. Let me suggest percentile_in and percentile_out.

Member

murrant commented Oct 6, 2017

You could change the labels to be more consistent. Let me suggest percentile_in and percentile_out.

yunchih added a commit to yunchih/librenms that referenced this issue Oct 6, 2017

yunchih added a commit to yunchih/librenms that referenced this issue Oct 6, 2017

@yunchih yunchih referenced this issue Oct 6, 2017

Merged

feature: Configurable 95th percentile #7442

0 of 1 task complete

yunchih added a commit to yunchih/librenms that referenced this issue Oct 7, 2017

laf added a commit that referenced this issue Oct 11, 2017

@laf laf closed this Oct 11, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.