Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transport options when edited on Windows #10001

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Mar 19, 2019

Windows puts line returns as \r\n, when parsing LibreNMS previously left the \r, which could cause issues
Centralize the code so we just have one place to fix.
Try to fix SMSEagle, it had the options wrong (copied from another transport)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix transport options when edited on Windows
Windows puts line returns as \r\n, when parsing LibreNMS previously left the \r, which could cause issues
Centralize the code so we just have one place to fix.
Try to fix SMSEagle, it had the options wrong (copied from another transport)
@dracmic

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Hello,

I am using this PR from over a week and it works. Could be merged?

@murrant murrant merged commit ac1cd12 into librenms:master Mar 27, 2019

1 of 2 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:tranport-fixes branch Mar 27, 2019

@laf laf changed the title Fix transport options when edited on Windows Fixed transport options when edited on Windows Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.