Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arris Apex support #10006

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@djamp42
Copy link
Contributor

commented Mar 20, 2019

Tested with Arris APEX-1000

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Hello @djamp42
Thanx for your PR. Could you have a look at the Codeclimate issues and solve them ? only a few blanks to remove as far as I can see.
And as I wrote in the YAML file, I am surprised not to see any modem counter. That seems surprising for a CMTS. You can use the "Count" sensor type for this kind of data.
The tests are important so I attached the NeedsTests tag, but better to finish the YAML model first before adding them.

@label-actions

This comment has been minimized.

Copy link

commented Mar 20, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@djamp42

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@PipoCanaja This is not a CMTS, it's a IP to QAM Modulator (EdgeQAM) used in cable tv headends.. I'll fix the code climate later tonight. Also I added the database json and snmpsim tests already, is there something else I need to add?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Other common value in cable operator world is noise. Nothing else to add in that direction ?
Concerning the tests, unless you add other sensors, should be already good.

@djamp42

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

No, this is sending out the qam signal so noise isn't measured here, nothing in the upstream direction either on this thing either. I looked to tried to find something for the hover graphs but nothing really made sense.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit fbfed49 into librenms:master Mar 21, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Add Device Arris Apex Added Arris Apex support Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add Device Arris Apex (librenms#10006)
* device arris-apex

* Code Climate Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.