Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Huawei BGP polling + BGP webui & graphs patches #10010

Merged
merged 5 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 21, 2019

In an attempt to improve Huawei VRP BGP support, I patched the webui as well (AFI & SAFI were not always correct). Currently testing it with both Cisco & Huawei.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10010
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja self-assigned this Mar 21, 2019

@PipoCanaja PipoCanaja changed the title WIP - Improve BGP Prefixes display + Huawei BGP polling WIP - Improve Huawei BGP polling + BGP webui & graphs patches Mar 21, 2019

@PipoCanaja PipoCanaja added the Graphs label Mar 21, 2019

@jozefrebjak

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@PipoCanaja will be possible to add accepted, denied, advertised, suppressed, withdrawn prefixes to graph ?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

@PipoCanaja will be possible to add accepted, denied, advertised, suppressed, withdrawn prefixes to graph ?

In the current state of this WIP, the graphs displays in the default display:

$ds_in  = 'AcceptedPrefixes';
$ds_out = 'AdvertisedPrefixes';

Would you add the 3 others to the same graph ? I would rather use a dedicated graph for detailed prefixes graphs. Some OS are not providing all the values anyway.

I'll try to come with something in this direction (will probably take some time, lower availability these days)

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

I don't have any device with those denied and supressed etc etc values available in my test lab @jozefrebjak . So I'll leave it how it is for now and finalize this PR to a working and tested state.

@PipoCanaja PipoCanaja changed the title WIP - Improve Huawei BGP polling + BGP webui & graphs patches Improve Huawei BGP polling + BGP webui & graphs patches Mar 23, 2019

@jozefrebjak

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@PipoCanaja ok, thank you anyway ;)

@PipoCanaja PipoCanaja added this to the 1.51 milestone Mar 26, 2019

@@ -53,12 +53,12 @@
echo ' | ';
if ($vars['view'] == 'prefixes_vpnv4unicast') {

This comment has been minimized.

Copy link
@laf

laf Apr 3, 2019

Member

How come you've changed the names of these?

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Apr 3, 2019

Author Contributor

The short answer would probably be : Because that's the name of the graph files in html/includes/graphs/bgp :)

But the reason behind it, is that this is built out of AFI and SAFI. VPNv4Unicast is a pure Cisco name, but the official structure is "ipv4 vpn" :

AFI=1 -> ipv4
AFI=2 -> ipv6
SAFI=1 -> unicast
SAFI=2 -> unicast
SAFI=128 -> vpn-unicast
SAFI=129 -> vpn-multicast

So combining them :

AFI=1, SAFI=1, IPv4 unicast
AFI=1, SAFI=2, IPv4 multicast
AFI=1, SAFI=128, L3VPN IPv4 unicast -> cisco vpnv4 unicast
AFI=1, SAFI=129, L3VPN IPv4 multicast 

AFI=2, SAFI=1, IPv6 unicast
AFI=2, SAFI=2, IPv6 multicast
AFI=2, SAFI=128, L3VPN IPv6 unicast -> cisco vpnv6 unicast
AFI=2, SAFI=129, L3VPN IPv6 multicast 

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Apr 3, 2019

Author Contributor

So the current LibreNMS master does not display anything for vpnv4 unicast, even if you have cisco routers. There are a few other inconsistancies in the BGP and VRF code, catching them as I build a new MPLS network in my company ;)

@laf laf added Polling Discovery and removed Polling labels Apr 9, 2019

@laf laf merged commit e285a92 into librenms:master Apr 9, 2019

1 of 2 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.