Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for DELLEMC-OS10-PRODUCTS-MIB (os: dell-os10) #10011

Merged
merged 3 commits into from Apr 1, 2019

Conversation

Projects
None yet
4 participants
@spencerbutler
Copy link
Contributor

commented Mar 22, 2019

Fixes:
#9966

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@spencerbutler spencerbutler referenced this pull request Mar 22, 2019

Closed

New device: Dell Networking S4128F-ON #9966

3 of 3 tasks complete
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Looks good as far as I can see. Let see the results of the test with the issue submitter.

@MrXermon

This comment has been minimized.

Copy link

commented Mar 29, 2019

Looks good from my point of view.

@PipoCanaja PipoCanaja added this to the 1.51 milestone Mar 29, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM. Will be merged after release 1.50.

@PipoCanaja PipoCanaja merged commit 6b4f247 into librenms:master Apr 1, 2019

1 of 2 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Release done, let's merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.