Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support dellNet devices #10016

Merged
merged 14 commits into from Apr 12, 2019

Conversation

Projects
None yet
6 participants
@spencerbutler
Copy link
Contributor

commented Mar 24, 2019

Fixes:
#9603

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

@spencerbutler
We can keep the PR a little bit before merging, so that we can take into account feedback we may receive on it, if you can have the requester testing this. Let me know.

@t0i

This comment has been minimized.

Copy link

commented Mar 25, 2019

root@librenms:/opt/librenms/scripts# ./github-apply 10016
:289: trailing whitespace.

:290: trailing whitespace.
The following objects are added by Dell.
:292: space before tab in indent.
dellNetBgpM2PeerInKeepalives,
:293: trailing whitespace, space before tab in indent.
dellNetBgpM2PeerOutKeepalives,
:294: trailing whitespace, space before tab in indent.
dellNetBgpM2PeerInOpen,
warning: squelched 1218 whitespace errors
warning: 1223 lines add whitespace errors.

I then went to the Dell S4048-ON and did a rediscover, but found no change.
I restarted librenms via an nginx restart to see if that would help, but found no difference.
I did a capture of the Discovery again, and didn't find it using new MIBs

Dell S Series Chassis

SNMP['/usr/bin/snmpbulkwalk' '-v2c' '-c' 'COMMUNITY' '-OQUs' '-m' 'F10-S-SERIES-CHASSIS-MIB' '-M' '/opt/librenms/mibs:/opt/librenms/mibs/dell:/opt/librenms/mibs/f10' 'udp:HOSTNAME:161' 'chStackUnitCpuUtil5Sec']

Can you let me know how to test this out properly?

@t0i

This comment has been minimized.

Copy link

commented Mar 25, 2019

I see the github-apply didn't download file i don't have:

root@librenms:/opt/librenms/includes/definitions/discovery# cat dell-net.yaml
cat: dell-net.yaml: No such file or directory

Edit: got it working, seems i had to su to librenms user first, based off a forum post i found some instructions to follow....

root@librenms:/opt/librenms# su - librenms
Last login: Mon Mar 25 09:09:53 PDT 2019 on pts/1
librenms@librenms:$ cat /etc/librenms_environment
cat: /etc/librenms_environment: No such file or directory
librenms@librenms:
$ cd /opt/librenms
librenms@librenms:~$ ./scripts/github-apply 10016
:289: trailing whitespace.

:290: trailing whitespace.
The following objects are added by Dell.
:292: space before tab in indent.
dellNetBgpM2PeerInKeepalives,
:293: trailing whitespace, space before tab in indent.
dellNetBgpM2PeerOutKeepalives,
:294: trailing whitespace, space before tab in indent.
dellNetBgpM2PeerInOpen,
Checking patch includes/definitions/dell-net.yaml...
Checking patch includes/definitions/discovery/dell-net.yaml...
Checking patch includes/discovery/mempools/dell-net.inc.php...
Checking patch includes/polling/mempools/dell-net.inc.php...
Checking patch includes/polling/os/dell-net.inc.php...
Checking patch mibs/dell/DELL-NETWORKING-BGP4-V2-MIB...
Checking patch mibs/dell/DELL-NETWORKING-BMP-MIB...
Checking patch mibs/dell/DELL-NETWORKING-BPSTATS-MIB...
Checking patch mibs/dell/DELL-NETWORKING-DCB-MIB...
Checking patch mibs/dell/DELL-NETWORKING-FIB-MIB...
Checking patch mibs/dell/DELL-NETWORKING-FIPSNOOPING-MIB...
Checking patch mibs/dell/DELL-NETWORKING-FPSTATS-MIB...
Checking patch mibs/dell/DELL-NETWORKING-IF-EXTENSION-MIB...
Checking patch mibs/dell/DELL-NETWORKING-ISIS-MIB...
Checking patch mibs/dell/DELL-NETWORKING-LINK-AGGREGATION-MIB...
Checking patch mibs/dell/DELL-NETWORKING-MAC-NOTIFICATION-MIB...
Checking patch mibs/dell/DELL-NETWORKING-OPENFLOW-MIB...
Checking patch mibs/dell/DELL-NETWORKING-PRODUCTS-MIB...
Checking patch mibs/dell/DELL-NETWORKING-SYSLOG-MIB...
Checking patch mibs/dell/DELL-NETWORKING-SYSTEM-COMPONENT-MIB...
Checking patch mibs/dell/DELL-NETWORKING-TRAP-EVENT-MIB...
Checking patch mibs/dell/DELL-NETWORKING-VIRTUAL-LINK-TRUNK-MIB...
Checking patch tests/data/dell-net.json...
Checking patch tests/snmpsim/dell-net.snmprec...
Applied patch includes/definitions/dell-net.yaml cleanly.
Applied patch includes/definitions/discovery/dell-net.yaml cleanly.
Applied patch includes/discovery/mempools/dell-net.inc.php cleanly.
Applied patch includes/polling/mempools/dell-net.inc.php cleanly.
Applied patch includes/polling/os/dell-net.inc.php cleanly.
Applied patch mibs/dell/DELL-NETWORKING-BGP4-V2-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-BMP-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-BPSTATS-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-DCB-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-FIB-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-FIPSNOOPING-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-FPSTATS-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-IF-EXTENSION-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-ISIS-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-LINK-AGGREGATION-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-MAC-NOTIFICATION-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-OPENFLOW-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-PRODUCTS-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-SYSLOG-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-SYSTEM-COMPONENT-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-TRAP-EVENT-MIB cleanly.
Applied patch mibs/dell/DELL-NETWORKING-VIRTUAL-LINK-TRUNK-MIB cleanly.
Applied patch tests/data/dell-net.json cleanly.
Applied patch tests/snmpsim/dell-net.snmprec cleanly.
warning: squelched 1226 whitespace errors
warning: 1231 lines add whitespace errors.
librenms@librenms:$ cd /opt/librenms/includes/definitions/discovery/
librenms@librenms:
/includes/definitions/discovery$ ll dell*
-rw-rw-r-- 1 librenms librenms 3006 Mar 25 09:50 dell-net.yaml
-rw-r--r-- 1 librenms librenms 4724 Nov 11 00:15 dell-rpdu.yaml
-rw-r--r-- 1 librenms librenms 858 Nov 11 00:15 dell-ups.yaml

I'll post results in another reply.

@t0i

This comment has been minimized.

Copy link

commented Mar 25, 2019

So i did a 'rediscover device' after the github-apply command which downloaded your dell-net.yaml files and the php files.

It looks like the dnos yaml and dell-net yaml are conflicting.

I then saw this in the eventlogs:
2019-03-25 09:40:03 system SWITCHNAME Device OS changed dell-net => dnos System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: state dellNetFanTrayOperStatus 2.1.1 Fantray 1 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: state dellNetFanTrayOperStatus 2.1.2 Fantray 2 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: state dellNetFanTrayOperStatus 2.1.3 Fantray 3 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: state dellNetPowerSupplyOperStatus 2.1.1 PSU 1 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: state dellNetPowerSupplyOperStatus 2.1.2 PSU 2 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 1 Stack Unit 1 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2097156 Transceiver 2097156 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2097284 Transceiver 2097284 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2097412 Transceiver 2097412 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2097540 Transceiver 2097540 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2097924 Transceiver 2097924 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2098052 Transceiver 2098052 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2100356 Transceiver 2100356 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2103301 Transceiver 2103301 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2105349 Transceiver 2105349 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Added: temperature dell-net 2105861 Transceiver 2105861 System
2019-03-25 09:39:59 sensor SWITCHNAME Sensor Deleted: temperature dnos 1 Unit 1 System
2019-03-25 09:39:57 processors SWITCHNAME Processor Discovered: dell-net dellNetCpuUtil1Min.2.1.1 1m Utilization System
2019-03-25 09:39:57 processors SWITCHNAME Processor Discovered: dell-net dellNetCpuUtil5Min.2.1.1 5m Utilization System
2019-03-25 09:39:53 | system | SWITCHNAME | Device OS changed dnos => dell-net | System

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@t0i Thanks for giving that a test. I pushed a commit to fix the conflict you are seeing. Can you do a git pull and rediscover you device please?

@t0i

This comment has been minimized.

Copy link

commented Mar 25, 2019

The new version has the following working:

  • CPU temps are picked up and are graphing
  • Memory utilization shows
  • Transceiver temperatures are collected

Refinements requested:

  • Add Transceiver Send/Receive power
  • Map the transceiver id to an interface name (Instead of 'Transceiver 2097156' translate that to 'Te1/1' or something)
  • Memory Pool is called Memorystack.1.1, Could it be renamed to just Memory Utilization or something more appropriate to what.
  • Memory is showing incorrect data.
    dellNetProcessorMemSize.stack.1.1 = 3053 is what is output in the Discovery debug
#show memory
     Statistics On Unit 1 Processor
     ===========================
   Total(b)      Used(b)       Free(b)      Lowest(b)      Largest(b)
  3201302528       3686432    3197616096   3197433892   3197616096

is what is output on the switch itself.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

The new version has the following working:

  • CPU temps are picked up and are graphing
  • Memory utilization shows
  • Transceiver temperatures are collected

Refinements requested:

  • Add Transceiver Send/Receive power
  • Map the transceiver id to an interface name (Instead of 'Transceiver 2097156' translate that to 'Te1/1' or something)
  • Memory Pool is called Memorystack.1.1, Could it be renamed to just Memory Utilization or something more appropriate to what.
  • Memory is showing incorrect data.
    dellNetProcessorMemSize.stack.1.1 = 3053 is what is output in the Discovery debug
#show memory
     Statistics On Unit 1 Processor
     ===========================
   Total(b)      Used(b)       Free(b)      Lowest(b)      Largest(b)
  3201302528       3686432    3197616096   3197433892   3197616096

is what is output on the switch itself.

Thanks for the feedback. I'll rework these.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

I'll update this PR once I resolve the other issues.

commit 9096d10 should fix these issues. The snmpwalk data I have from you doesn't include any Tx/Rx data for your transceivers, so I couldn't test that. Let me know if it works as expected.

@t0i

This comment has been minimized.

Copy link

commented Mar 25, 2019

#show memory
Statistics On Unit 1 Processor

Total(b) Used(b) Free(b) Lowest(b) Largest(b)
3201302528 3686432 3197616096 3197433892 3197616096

is what is output on the switch itself.

As far as the discrepancy for the total memory value -- the value is converted by the SNMP agent.

3201302528/1024/1024
3053.00000000000000000000

I'll update this PR once I resolve the other issues.

Thanks but the rrdtool thinks its 3.68 kB instead of 3053MB

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Thanks but the rrdtool thinks its 3.68 kB instead of 3053MB
good catch. I will fix.

update

We don't get enough information from the device to tell which power of 2 to assign the device. All we get is the percent used of the total size. I can multiply it by whatever, but the data is still going to represent the same thing.

The values we get from the device

dellNetProcessorMemSize.stack.1.1 = 3029
dellNetCpuUtilMemUsage.stack.1.1 = 28

The calculation

28/100 * 3029 = used units (848.12)

The value stored in the RRD file

ds[usage].last_ds = "28"

spencerbutler added some commits Mar 26, 2019

@t0i

This comment has been minimized.

Copy link

commented Mar 26, 2019

I'll update this PR once I resolve the other issues.

commit 9096d10 should fix these issues. The snmpwalk data I have from you doesn't include any Tx/Rx data for your transceivers, so I couldn't test that. Let me know if it works as expected.

in issue #9603 I did mention a section "Optic Details" which shows the SNMPwalk showing OIDs for Rx/Tx levels and voltages.

Here it is:

root@librenms:/opt/librenms# snmpwalk -On -v2c -c XXCOMMUNITYXX S4048-ON DELL-NETWORKING-IF-EXTENSION-MIB::dellNetIfTransceiverDataTable
.1.3.6.1.4.1.6027.3.11.1.3.1.1.1.2097156 = STRING: "stack-unit-1 port-1"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.1.2097284 = STRING: "stack-unit-1 port-2"
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.1.2105861 = STRING: "stack-unit-1 port-54"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.2.2097156 = STRING: "Te 1/1"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.2.2097284 = STRING: "Te 1/2"
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.2.2105861 = STRING: "Fo 1/54"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.3.2097156 = INTEGER: true(1)
.1.3.6.1.4.1.6027.3.11.1.3.1.1.3.2097284 = INTEGER: true(1)
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.3.2105861 = INTEGER: true(1)
.1.3.6.1.4.1.6027.3.11.1.3.1.1.4.2097156 = STRING: "10GBASE-SR"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.4.2097284 = STRING: "10GBASE-SR"
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.4.2105861 = STRING: "40GBASE-CR4-0.5M"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.5.2097156 = STRING: "DELL"
.1.3.6.1.4.1.6027.3.11.1.3.1.1.5.2097284 = STRING: "DELL"
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.8.2097156 = STRING: "-2.307704" dBm
.1.3.6.1.4.1.6027.3.11.1.3.1.1.8.2097284 = STRING: "-2.336615" dBm
<snipped for brevity><snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.12.2097156 = STRING: "-3.226669" dBm
.1.3.6.1.4.1.6027.3.11.1.3.1.1.12.2097284 = STRING: "-3.163227" dBm
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.16.2097156 = STRING: "35.566406" degree Celsius
.1.3.6.1.4.1.6027.3.11.1.3.1.1.16.2097284 = STRING: "34.886719" degree Celsius
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.17.2097156 = STRING: "3.307200" volts
.1.3.6.1.4.1.6027.3.11.1.3.1.1.17.2097284 = STRING: "3.314500" volts
<snipped for brevity>
.1.3.6.1.4.1.6027.3.11.1.3.1.1.18.2097156 = STRING: "6.550000" mA
.1.3.6.1.4.1.6027.3.11.1.3.1.1.18.2097284 = STRING: "6.542000" mA
<snipped for brevity>
@t0i

This comment has been minimized.

Copy link

commented Mar 26, 2019

Can confirm the optic levels look to be working.
One improvement to be made is to know if I'm looking at 'Rx' or 'Tx'.

Also, it looks to be grabbing unnecessary "Lanes" values.

So what I see for the DBm summary on the device overview page is:
Lane 1:
A list of all the optics, and a value. Not sure which value is which, I imagine the first value is Transmit and second value is Receive. Would be good to indicate which is which.

ie.

Te 1/1 10GBASE-SR  -2.450404dBm
Te 1/1 10GBASE-SR  -2.635238dBm
Te 1/2 10GBASE-SR  -2.391254dBm
Te 1/2 10GBASE-SR  -2.709162dBm

etc.

Lane 3:
A repeat of the list of all the optics, but all values are 0 dBM. And each optic is only listed once instead of twice.

i.e.

Te 1/1 10GBASE-SR  0dBm
Te 1/2 10GBASE-SR  0dBm
Te 1/26 10GBASE-LR  0dBm

Current
under the current section, there's 4 lanes worth of data.

Lane1 is correct:

Fo 1/49 40GBASE-SR4 |   | 0A
Fo 1/53 40GBASE-CR4-0.5M |   | 0A
Fo 1/54 40GBASE-CR4-0.5M |   | 0A
Te 1/1 10GBASE-SR |   | 8.952A
Te 1/2 10GBASE-SR |   | 8.936A
Te 1/26 10GBASE-LR |   | 24.879999A
Te 1/3 10GBASE-SR |   | 8.942A
Te 1/4 10GBASE-SR |   | 8.988A
Te 1/7 10GBASE-SR |   | 8.884A
Te 1/8 10GBASE-SR |   | 8.94A

However Lane 2, Lane 3, and Lane 4 all show 0A values.

Lane 2
Fo 1/49 40GBASE-SR4 |   | 0A
Fo 1/53 40GBASE-CR4-0.5M |   | 0A
Fo 1/54 40GBASE-CR4-0.5M |   | 0A
Lane 3
Fo 1/49 40GBASE-SR4 |   | 0A
Fo 1/53 40GBASE-CR4-0.5M |   | 0A
Fo 1/54 40GBASE-CR4-0.5M |   | 0A
Lane 4
Fo 1/49 40GBASE-SR4 |   | 0A
Fo 1/53 40GBASE-CR4-0.5M |   | 0A
Fo 1/54 40GBASE-CR4-0.5M |   | 0A

Thanks,

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Can confirm the optic levels look to be working.
One improvement to be made is to know if I'm looking at 'Rx' or 'Tx'.

I've added Rx/Tx indicators in a17a3fa, can you see if that looks OK?

@t0i

This comment has been minimized.

Copy link

commented Mar 26, 2019

Can confirm the optic levels look to be working.
One improvement to be made is to know if I'm looking at 'Rx' or 'Tx'.

I've added Rx/Tx indicators in a17a3fa, can you see if that looks OK?

Rx/Tx now looks good. However, any way to find out how to remove unnecessary Lanes?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@t0i Could you provide a complete snmpwalk (including your optics etc) to @spencerbutler ? If you don't want to anonymize it, just send it to him private. That would make it far easier for him to test and filter unnecessary data.

@t0i

This comment has been minimized.

Copy link

commented Mar 28, 2019

I can provide a mostly sanitized snmpbulkwalk directly to whoever needs it. Will have to provide it privately.

I'm also curious where the sensor thresholds come from for the optics.

Great work so far. Just need to get rid of the unnecessary lanes/ignore the 0 values as cloudprodz has mentioned above. Does this also mean we need to re-discover if we insert a new optic? Or how does that work? Does a rediscover occur nightly automatically?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

It depends how you schedule your discovery. It takes place in the cron librenms script. The discovery will add any sensor that appeared since the last discovery.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@t0i Contact me on discord to send me a snmpwalk file.

@t0i

This comment has been minimized.

Copy link

commented Apr 1, 2019

@PipoCanaja snmpwalk sent. Let me know if more is needed.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

Hi @spencerbutler
The dell net os already existed in the form of dnos.yaml. Your new one clearly overlaps with existing. Is there something wrong with existing ? mixes too many different devices ?
If you need to keep the split, then you have to exlude all devices in your dell-net from the existing dnos.
@t0i I started to test this and that 1st step is to clearly define if we have a new OS to create or an existing one to extend.

@PipoCanaja PipoCanaja changed the title Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net) WIP Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net) Apr 2, 2019

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Hi @spencerbutler
The dell net os already existed in the form of dnos.yaml. Your new one clearly overlaps with existing. Is there something wrong with existing ? mixes too many different devices ?
If you need to keep the split, then you have to exlude all devices in your dell-net from the existing dnos.
@t0i I started to test this and that 1st step is to clearly define if we have a new OS to create or an existing one to extend.

It uses a different set of MIBs.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

The main issue with adding this to the dnos OS can be found in Dnos.php L45 where there is a conflict with the base Product OID. The original code assumes the switch is FTOS based. The following example better illustrates my point. Let me know the best way to proceed in incorporating the new style Dell Networking OS.

Force10 OS

$ snmptranslate -Td -M mibs:mibs/f10 -m all .1.3.6.1.4.1.6027.1.3
F10-PRODUCTS-MIB::f10SSeriesProducts
f10SSeriesProducts OBJECT-IDENTITY
-- FROM F10-PRODUCTS-MIB
DESCRIPTION "This object identifier roots Dell Networking OS S-Series product
object identifiers."
::= { iso(1) org(3) dod(6) internet(1) private(4) enterprises(1) force10(6027) f10Products(1) 3 }

Dell Networking OS

$ snmptranslate -Td -M mibs:mibs/dell -m all .1.3.6.1.4.1.6027.1.3
DELL-NETWORKING-PRODUCTS-MIB::dellNetSSeriesProducts
dellNetSSeriesProducts OBJECT-IDENTITY
-- FROM DELL-NETWORKING-PRODUCTS-MIB
DESCRIPTION "This object identifier roots Dell Networking OS S-Series product
object identifiers."
::= { iso(1) org(3) dod(6) internet(1) private(4) enterprises(1) dellNet(6027) dellNetProducts(1) 3 }

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

@spencerbutler
Try to find any OID in one device that is not reachable on the other one. And you can add an snmpget statement to only match one OS or the other on purpose.
Like ruckuswireless.yaml:

discovery:
    - sysObjectID: .1.3.6.1.4.1.25053.3.1.5
      snmpget:
          oid: '.1.3.6.1.4.1.25053.1.2.1.1.1.1.9.0'
          op: starts
          value: [ ZD, zd ]
@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

@spencerbutler
Try to find any OID in one device that is not reachable on the other one. And you can add an snmpget statement to only match one OS or the other on purpose.
Like ruckuswireless.yaml:

discovery:
    - sysObjectID: .1.3.6.1.4.1.25053.3.1.5
      snmpget:
          oid: '.1.3.6.1.4.1.25053.1.2.1.1.1.1.9.0'
          op: starts
          value: [ ZD, zd ]

I found unique sysObjectID's for this device and several other "S Series" devices that aren't defined in the F10 base.

@murrant
Copy link
Member

left a comment

This needs to be merged into the dnos OS. I don't see any reason to make a new os.

@spencerbutler spencerbutler changed the title WIP Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net) Added support dellNet devices Apr 7, 2019

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

This needs to be merged into the dnos OS. I don't see any reason to make a new os.

fixed

@laf

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

If you can remove the dell net test files you'd added this may pass tests afterwards and can be merged.

@laf laf added User-Pending and removed Needs Testing labels Apr 9, 2019

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

If you can remove the dell net test files you'd added this may pass tests afterwards and can be merged.

fixed

@laf laf removed the User-Pending label Apr 9, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Looks good, this was a long ride :) If there are any further improvements, we'll just do a new PR.

@murrant murrant merged commit c76115b into librenms:master Apr 12, 2019

5 of 6 checks passed

codeclimate 6 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@MrXermon MrXermon referenced this pull request Apr 12, 2019

Open

DELL S4048-ON/S3048-ON healthstate-sensors missing #8259

5 of 5 tasks complete

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added support dellNet devices (librenms#10016)
* Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net)

* dell-net - created mempool, removed flash (not enough data points)

* dell-net - updated yaml sysObjectIDs

* dell-net - added sensors, fixed sensors

* clean up

* dell-net added Tx/Rx indicators

* dell-net - regroup Lanes

* dell-net remove Lane quotes, removed random files

* dell-net - updated Model description per requester

* added rules to ignore 0 values

* restricted discovery match

* merge dellNet into os: dnos

* typo

* remove dell-net test files

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added support dellNet devices (librenms#10016)
* Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net)

* dell-net - created mempool, removed flash (not enough data points)

* dell-net - updated yaml sysObjectIDs

* dell-net - added sensors, fixed sensors

* clean up

* dell-net added Tx/Rx indicators

* dell-net - regroup Lanes

* dell-net remove Lane quotes, removed random files

* dell-net - updated Model description per requester

* added rules to ignore 0 values

* restricted discovery match

* merge dellNet into os: dnos

* typo

* remove dell-net test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.