Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call to list all ports FDB #10020

Merged
merged 4 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@zombah
Copy link
Contributor

commented Mar 24, 2019

Add FDB API calls to resolve this forum request

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

zombah added some commits Mar 24, 2019

Add API call to list all ports FDB
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
Add API call to get FDB entries for given device
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
API call list FDB allow to query by mac
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
API call list FDB use count for both conditions
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>

@PipoCanaja PipoCanaja added the API label Apr 3, 2019

@laf

laf approved these changes Apr 9, 2019

Copy link
Member

left a comment

LGTM + Tested working.

@laf laf merged commit 7b4c63a into librenms:master Apr 9, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added API call to list all ports FDB (librenms#10020)
Add FDB API calls to resolve this [forum request](https://community.librenms.org/t/fdb-table-search-via-api-mac-ip-switch-port/1772/4) 

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added API call to list all ports FDB (librenms#10020)
Add FDB API calls to resolve this [forum request](https://community.librenms.org/t/fdb-table-search-via-api-mac-ip-switch-port/1772/4) 

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.