Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Fixed error when user doesn't exist #10023

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Mar 25, 2019

https://community.librenms.org/t/bugreport-daily-php-purgeusers-removes-user-with-valid-api-keys/7818

Should not affect behavior in any way. Just removes the backtrace when this happens.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Bug 🐞 label Mar 25, 2019

@murrant murrant changed the title Small auth fix Auth: fix error when user doesn't exist Mar 25, 2019

@murrant murrant added this to the 1.50 milestone Mar 25, 2019

@murrant murrant merged commit 960a75f into librenms:master Mar 27, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:small-auth-fix branch Mar 27, 2019

@laf laf changed the title Auth: fix error when user doesn't exist Auth: Fixed error when user doesn't exist Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.