Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing pipe in ports page menu #10025

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Projects
None yet
3 participants
@JoshWeepie
Copy link
Contributor

commented Mar 25, 2019

The ports page has a missing pipe in the menu between 'Update URL' and 'Search'.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix missing pipe in ports page menu
The ports page has a missing pipe in the menu between 'Update URL' and 'Search'.
@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Photo for reference.
missing pipe in navbar menu

@murrant murrant added the WebUI label Mar 25, 2019

@murrant murrant added this to the 1.50 milestone Mar 25, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Nice catch !

@PipoCanaja PipoCanaja merged commit 9037c07 into librenms:master Mar 25, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Fix missing pipe in ports page menu Fixed missing pipe in ports page menu Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix missing pipe in ports page menu (librenms#10025)
The ports page has a missing pipe in the menu between 'Update URL' and 'Search'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.