Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Ruijie Networks #10026

Merged
merged 2 commits into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@spencerbutler
Copy link
Contributor

commented Mar 26, 2019

fixes:
#8021

@hanserasmus Can you give this a try? If so, please submit a new discover, poller, and snmpwalk so I can add sensors and whatever else is missing.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@hanserasmus

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Hi @spencerbutler Thank you SO much for working on this.

I think the patch applied correctly, although I am not sure.

Github-apply

Herewith the three links to pastebin. I will keep my LibreNMS running on this device and see what happens. I will also test on another Ruijie model to see how it behaves.

System description      : Ruijie 10G Routing Switch(S6220-48XS4QXS) By Ruijie Networks
System start time       : 2019-02-23 11:1:2
System uptime           : 30:22:28:48
System hardware version : 1.17
System software version : RGOS 10.4(5b2)p2 Release(182500)
System BOOT version     : 10.4(5b2)p2 Release(182500)

Discovery
Poller
SNMPbulkwalk
The snmpbulkwalk gives the following errors still:

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.6887.12.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.5999.26.1

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.6887.12.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.5914.44.1

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.6887.12.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.5927.47.1

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.6887.12.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.5933.48.1

It seems it is not able to graph CPU, Memory or Temperatures on this device. But as stated above, not sure if the patch was applied correctly?

Does this help at all?

Thank you again!

@hanserasmus

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Here is the output for a Ruijie 5750.

System description      : Ruijie 10G Routing Switch(S5750-24SFP/8GT-E) By Ruijie Networks
System start time       : 2017-07-21 5:53:52
System uptime           : 613:12:26:52
System hardware version : 1.06
System software version : RGOS 10.4(3b16)p2 Release(178747)
System BOOT version     : 10.4(3b16)p2 Release(178747)
System CTRL version     : 10.4(3b16)p2 Release(178747)

Discovery
Poller
SNMPbulkwalk

When running SNMPBulkwalk I still get this error

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.973403460.21.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.8487.26.1

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.973403460.21.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.559905836.27.1
@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.973403460.21.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.8487.26.1

Error: OID not increasing: .1.0.8802.1.1.2.1.4.1.1.4.973403460.21.1
 >= .1.0.8802.1.1.2.1.4.1.1.4.559905836.27.1

I believe this is because of the old MIBs that are in use. Your particular model isn't listed in the PRODUCT-MIB. If you can contact the vendor and obtain current MIBs for these, it would greatly help the support LibrenNMS can provide.

@hanserasmus

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

I have sent through the request, so now we hold our breaths to see if they are willing to help. Thank you for the help here!

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@spencerbutler You can either put this in WIP or decide to merge this and come back to it later if new MIBs become available. Let me know.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@spencerbutler You can either put this in WIP or decide to merge this and come back to it later if new MIBs become available. Let me know.

Let's merge it in. I'll pick it back up if we get some newer/working MIB files.

Extend discovery
Let's extend to all the products from this brand, at least until we have more detailed discovery
@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

I extended to all the RUIJIE products (according to MIB) which includes Switches, Routers and Wireless. The logo and default device discovery will be there.

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 26, 2019

@PipoCanaja PipoCanaja merged commit 2ad13f1 into librenms:master Mar 26, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@spencerbutler spencerbutler deleted the spencerbutler:feature/ruijie branch Mar 26, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added support for Ruijie Networks (librenms#10026)
* Added support for Ruijie Networks

* Extend discovery

Let's extend to all the products from this brand, at least until we have more detailed discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.