Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for IONODES video encoders #10031

Merged
merged 5 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@priiduonu
Copy link
Contributor

commented Mar 26, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@@ -0,0 +1,35 @@
mib: IF-MIB::IONODES-IONSERIES-MIB

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Mar 27, 2019

Contributor

You need only one ':' here and not two

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Hi @priiduonu
Thank you for your PR. A few comments inline !
Bye

@PipoCanaja PipoCanaja added this to the 1.51 milestone Mar 28, 2019

@priiduonu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Thanks for Your comments @PipoCanaja ! Made the suggested changes.

@@ -0,0 +1,35 @@
mib: IF-MIB:IONODES-IONSERIES-MIB

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Mar 28, 2019

Contributor

You do not use IF-MIB, do you ? if not, you can remove it from here and only keep IONODES-IONSERIES-MIB

@priiduonu

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Keeps working :-)

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

If it is fine with your tests, we will be able to merge that next week after next release.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM, will be merged after release

@PipoCanaja PipoCanaja merged commit 5fc2f18 into librenms:master Apr 1, 2019

5 of 6 checks passed

codeclimate 3 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

Release done, let's merge this.

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added support for IONODES video encoders (librenms#10031)
* Added support for IONODES video encoders

* fixed expected number instead of string value error when running tests

* removed extra colon

* added mibs_dir for ionodes

* removed IF-MIB from ionodes.yaml

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Added support for IONODES video encoders (librenms#10031)
* Added support for IONODES video encoders

* fixed expected number instead of string value error when running tests

* removed extra colon

* added mibs_dir for ionodes

* removed IF-MIB from ionodes.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.